-
Notifications
You must be signed in to change notification settings - Fork 216
add CORS headers to responses #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is good approach to enable the connection over CORS. For merging, we would need to make those parameters |
It's complicated, I'll make them configurable from the CLI in another merge request later. |
ok, we can do it in steps |
Following VLLM params: https://github.com/vllm-project/vllm/blob/ed70f3c64f684750edea087e286cbf264e7cc3f3/vllm/entrypoints/openai/cli_args.py#L100-L114 This is related to: #3412 #3417 This allows Open WebUI integration. CVS-169897
Following VLLM params: https://github.com/vllm-project/vllm/blob/ed70f3c64f684750edea087e286cbf264e7cc3f3/vllm/entrypoints/openai/cli_args.py#L100-L114 This is related to: #3412 #3417 This allows Open WebUI integration. CVS-169897
Following VLLM params: https://github.com/vllm-project/vllm/blob/ed70f3c64f684750edea087e286cbf264e7cc3f3/vllm/entrypoints/openai/cli_args.py#L100-L114 This is related to: #3412 #3417 This allows Open WebUI integration. CVS-169897
Details:
Tickets: