Skip to content

add CORS headers to responses #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Huanli-Gong
Copy link

@Huanli-Gong Huanli-Gong commented Jun 17, 2025

Details:

  • add CORS headers to handle cross-origin request.

Tickets:

@dtrawins dtrawins requested a review from dkalinowski June 18, 2025 13:20
@dtrawins
Copy link
Collaborator

This is good approach to enable the connection over CORS. For merging, we would need to make those parameters
allow_origins=[""], # list of strings
allow_credentials=True, # bool
allow_methods=["
"], # list of strings
allow_headers=["*"], # list of strings
configurable from the CLI

@Huanli-Gong
Copy link
Author

Huanli-Gong commented Jun 18, 2025

This is good approach to enable the connection over CORS. For merging, we would need to make those parameters allow_origins=[""], # list of strings allow_credentials=True, # bool allow_methods=[""], # list of strings allow_headers=["*"], # list of strings configurable from the CLI

It's complicated, I'll make them configurable from the CLI in another merge request later.

@mzegla mzegla added the GSoC Contributions that are part of Google Summer of Code projects label Jun 25, 2025
@dtrawins
Copy link
Collaborator

ok, we can do it in steps

@dkalinowski dkalinowski mentioned this pull request Jul 1, 2025
3 tasks
dkalinowski added a commit that referenced this pull request Jul 4, 2025
dkalinowski added a commit that referenced this pull request Jul 4, 2025
dkalinowski added a commit that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Contributions that are part of Google Summer of Code projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CORS support
4 participants