Skip to content

Commit 5c1e448

Browse files
author
epriestley
committed
Remove all "Phabricator Bot" code
Summary: Closes T7829 as wontfix. Closes T7965 as wontfix. Closes T7800 as wontfix. Closes T2731 as wontfix. Closes T1271 as wontfix. We aren't maintaining this at all (see, e.g., T7829) and a user reported a technically accurate security issue via HackerOne: <https://hackerone.com/reports/222870> Just throw it away until we get to the eventual Conphernece bot/API update and can do this stuff correctly. Test Plan: Grepped for `phabricatorbot`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T7965, T7829, T7800, T2731, T1271 Differential Revision: https://secure.phabricator.com/D17756
1 parent ede23ef commit 5c1e448

20 files changed

+0
-1933
lines changed

‎src/__phutil_library_map__.php

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -2089,20 +2089,6 @@
20892089
'PhabricatorBoardRenderingEngine' => 'applications/project/engine/PhabricatorBoardRenderingEngine.php',
20902090
'PhabricatorBoardResponseEngine' => 'applications/project/engine/PhabricatorBoardResponseEngine.php',
20912091
'PhabricatorBoolEditField' => 'applications/transactions/editfield/PhabricatorBoolEditField.php',
2092-
'PhabricatorBot' => 'infrastructure/daemon/bot/PhabricatorBot.php',
2093-
'PhabricatorBotChannel' => 'infrastructure/daemon/bot/target/PhabricatorBotChannel.php',
2094-
'PhabricatorBotDebugLogHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotDebugLogHandler.php',
2095-
'PhabricatorBotFeedNotificationHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php',
2096-
'PhabricatorBotFlowdockProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php',
2097-
'PhabricatorBotHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotHandler.php',
2098-
'PhabricatorBotLogHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotLogHandler.php',
2099-
'PhabricatorBotMacroHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php',
2100-
'PhabricatorBotMessage' => 'infrastructure/daemon/bot/PhabricatorBotMessage.php',
2101-
'PhabricatorBotObjectNameHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotObjectNameHandler.php',
2102-
'PhabricatorBotSymbolHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotSymbolHandler.php',
2103-
'PhabricatorBotTarget' => 'infrastructure/daemon/bot/target/PhabricatorBotTarget.php',
2104-
'PhabricatorBotUser' => 'infrastructure/daemon/bot/target/PhabricatorBotUser.php',
2105-
'PhabricatorBotWhatsNewHandler' => 'infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php',
21062092
'PhabricatorBritishEnglishTranslation' => 'infrastructure/internationalization/translation/PhabricatorBritishEnglishTranslation.php',
21072093
'PhabricatorBuiltinDraftEngine' => 'applications/transactions/draft/PhabricatorBuiltinDraftEngine.php',
21082094
'PhabricatorBuiltinPatchList' => 'infrastructure/storage/patch/PhabricatorBuiltinPatchList.php',
@@ -2261,7 +2247,6 @@
22612247
'PhabricatorCalendarRemarkupRule' => 'applications/calendar/remarkup/PhabricatorCalendarRemarkupRule.php',
22622248
'PhabricatorCalendarReplyHandler' => 'applications/calendar/mail/PhabricatorCalendarReplyHandler.php',
22632249
'PhabricatorCalendarSchemaSpec' => 'applications/calendar/storage/PhabricatorCalendarSchemaSpec.php',
2264-
'PhabricatorCampfireProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php',
22652250
'PhabricatorCelerityApplication' => 'applications/celerity/application/PhabricatorCelerityApplication.php',
22662251
'PhabricatorCelerityTestCase' => '__tests__/PhabricatorCelerityTestCase.php',
22672252
'PhabricatorChangeParserTestCase' => 'applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php',
@@ -2921,7 +2906,6 @@
29212906
'PhabricatorHovercardEngineExtensionModule' => 'applications/search/engineextension/PhabricatorHovercardEngineExtensionModule.php',
29222907
'PhabricatorIDsSearchEngineExtension' => 'applications/search/engineextension/PhabricatorIDsSearchEngineExtension.php',
29232908
'PhabricatorIDsSearchField' => 'applications/search/field/PhabricatorIDsSearchField.php',
2924-
'PhabricatorIRCProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php',
29252909
'PhabricatorIconDatasource' => 'applications/files/typeahead/PhabricatorIconDatasource.php',
29262910
'PhabricatorIconRemarkupRule' => 'applications/macro/markup/PhabricatorIconRemarkupRule.php',
29272911
'PhabricatorIconSet' => 'applications/files/iconset/PhabricatorIconSet.php',
@@ -3654,7 +3638,6 @@
36543638
'PhabricatorProjectsSearchEngineExtension' => 'applications/project/engineextension/PhabricatorProjectsSearchEngineExtension.php',
36553639
'PhabricatorProjectsWatchersSearchEngineAttachment' => 'applications/project/engineextension/PhabricatorProjectsWatchersSearchEngineAttachment.php',
36563640
'PhabricatorPronounSetting' => 'applications/settings/setting/PhabricatorPronounSetting.php',
3657-
'PhabricatorProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorProtocolAdapter.php',
36583641
'PhabricatorPygmentSetupCheck' => 'applications/config/check/PhabricatorPygmentSetupCheck.php',
36593642
'PhabricatorQuery' => 'infrastructure/query/PhabricatorQuery.php',
36603643
'PhabricatorQueryConstraint' => 'infrastructure/query/constraint/PhabricatorQueryConstraint.php',
@@ -3978,7 +3961,6 @@
39783961
'PhabricatorStoragePatch' => 'infrastructure/storage/management/PhabricatorStoragePatch.php',
39793962
'PhabricatorStorageSchemaSpec' => 'infrastructure/storage/schema/PhabricatorStorageSchemaSpec.php',
39803963
'PhabricatorStorageSetupCheck' => 'applications/config/check/PhabricatorStorageSetupCheck.php',
3981-
'PhabricatorStreamingProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php',
39823964
'PhabricatorStringListEditField' => 'applications/transactions/editfield/PhabricatorStringListEditField.php',
39833965
'PhabricatorStringSetting' => 'applications/settings/setting/PhabricatorStringSetting.php',
39843966
'PhabricatorSubmitEditField' => 'applications/transactions/editfield/PhabricatorSubmitEditField.php',
@@ -7150,20 +7132,6 @@
71507132
'PhabricatorBoardRenderingEngine' => 'Phobject',
71517133
'PhabricatorBoardResponseEngine' => 'Phobject',
71527134
'PhabricatorBoolEditField' => 'PhabricatorEditField',
7153-
'PhabricatorBot' => 'PhabricatorDaemon',
7154-
'PhabricatorBotChannel' => 'PhabricatorBotTarget',
7155-
'PhabricatorBotDebugLogHandler' => 'PhabricatorBotHandler',
7156-
'PhabricatorBotFeedNotificationHandler' => 'PhabricatorBotHandler',
7157-
'PhabricatorBotFlowdockProtocolAdapter' => 'PhabricatorStreamingProtocolAdapter',
7158-
'PhabricatorBotHandler' => 'Phobject',
7159-
'PhabricatorBotLogHandler' => 'PhabricatorBotHandler',
7160-
'PhabricatorBotMacroHandler' => 'PhabricatorBotHandler',
7161-
'PhabricatorBotMessage' => 'Phobject',
7162-
'PhabricatorBotObjectNameHandler' => 'PhabricatorBotHandler',
7163-
'PhabricatorBotSymbolHandler' => 'PhabricatorBotHandler',
7164-
'PhabricatorBotTarget' => 'Phobject',
7165-
'PhabricatorBotUser' => 'PhabricatorBotTarget',
7166-
'PhabricatorBotWhatsNewHandler' => 'PhabricatorBotHandler',
71677135
'PhabricatorBritishEnglishTranslation' => 'PhutilTranslation',
71687136
'PhabricatorBuiltinDraftEngine' => 'PhabricatorDraftEngine',
71697137
'PhabricatorBuiltinPatchList' => 'PhabricatorSQLPatchList',
@@ -7358,7 +7326,6 @@
73587326
'PhabricatorCalendarRemarkupRule' => 'PhabricatorObjectRemarkupRule',
73597327
'PhabricatorCalendarReplyHandler' => 'PhabricatorApplicationTransactionReplyHandler',
73607328
'PhabricatorCalendarSchemaSpec' => 'PhabricatorConfigSchemaSpec',
7361-
'PhabricatorCampfireProtocolAdapter' => 'PhabricatorStreamingProtocolAdapter',
73627329
'PhabricatorCelerityApplication' => 'PhabricatorApplication',
73637330
'PhabricatorCelerityTestCase' => 'PhabricatorTestCase',
73647331
'PhabricatorChangeParserTestCase' => 'PhabricatorWorkingCopyTestCase',
@@ -8115,7 +8082,6 @@
81158082
'PhabricatorHovercardEngineExtensionModule' => 'PhabricatorConfigModule',
81168083
'PhabricatorIDsSearchEngineExtension' => 'PhabricatorSearchEngineExtension',
81178084
'PhabricatorIDsSearchField' => 'PhabricatorSearchField',
8118-
'PhabricatorIRCProtocolAdapter' => 'PhabricatorProtocolAdapter',
81198085
'PhabricatorIconDatasource' => 'PhabricatorTypeaheadDatasource',
81208086
'PhabricatorIconRemarkupRule' => 'PhutilRemarkupRule',
81218087
'PhabricatorIconSet' => 'Phobject',
@@ -8973,7 +8939,6 @@
89738939
'PhabricatorProjectsSearchEngineExtension' => 'PhabricatorSearchEngineExtension',
89748940
'PhabricatorProjectsWatchersSearchEngineAttachment' => 'PhabricatorSearchEngineAttachment',
89758941
'PhabricatorPronounSetting' => 'PhabricatorSelectSetting',
8976-
'PhabricatorProtocolAdapter' => 'Phobject',
89778942
'PhabricatorPygmentSetupCheck' => 'PhabricatorSetupCheck',
89788943
'PhabricatorQuery' => 'Phobject',
89798944
'PhabricatorQueryConstraint' => 'Phobject',
@@ -9377,7 +9342,6 @@
93779342
'PhabricatorStoragePatch' => 'Phobject',
93789343
'PhabricatorStorageSchemaSpec' => 'PhabricatorConfigSchemaSpec',
93799344
'PhabricatorStorageSetupCheck' => 'PhabricatorSetupCheck',
9380-
'PhabricatorStreamingProtocolAdapter' => 'PhabricatorProtocolAdapter',
93819345
'PhabricatorStringListEditField' => 'PhabricatorEditField',
93829346
'PhabricatorStringSetting' => 'PhabricatorSetting',
93839347
'PhabricatorSubmitEditField' => 'PhabricatorEditField',

‎src/docs/tech/chatbot.diviner

Lines changed: 0 additions & 87 deletions
This file was deleted.

‎src/infrastructure/daemon/bot/PhabricatorBot.php

Lines changed: 0 additions & 170 deletions
This file was deleted.

0 commit comments

Comments
 (0)