Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not displaying 405 #18391

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gewenyu99
Copy link
Contributor

@gewenyu99 gewenyu99 commented Mar 22, 2025

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

@gewenyu99 gewenyu99 force-pushed the fix-not-displaying-405 branch from 5a64dfb to b98b858 Compare March 22, 2025 02:24
Comment on lines 9426 to 9427
resp.writeStatus("405 Method Not Allowed");
resp.end("", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server must generate an Allow header in a 405 response with a list of methods that the target resource currently supports.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/405

@gewenyu99 gewenyu99 requested a review from nektro March 22, 2025 19:40
@gewenyu99
Copy link
Contributor Author

Screenshot 2025-03-25 at 3 48 32 PM Also question about these builds. I'm seeing 6/6 passes and exit code 2, is there something im missing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants