feat(combobox): implement multiple #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
requested changes
Jun 24, 2025
packages/examples/webpack-app/src/app/components/formNative/FormNative.tsx
Show resolved
Hide resolved
...ds-react/src/components/combobox/src/components/combobox-control/comboboxControl.module.scss
Outdated
Show resolved
Hide resolved
...ds-react/src/components/combobox/src/components/combobox-control/comboboxControl.module.scss
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-tags/ComboboxTags.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-tags/ComboboxTags.tsx
Outdated
Show resolved
Hide resolved
var-poro
force-pushed
the
ods-react-combobox-multiple
branch
from
92b0f76 to
f4d9891
Compare
var-poro
force-pushed
the
ods-react-combobox-multiple
branch
from
f4d9891 to
21ea968
Compare
dpellier
requested changes
Jun 25, 2025
packages/ods-react/src/components/combobox/src/components/combobox-tags/ComboboxTags.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/contexts/useCombobox.tsx
Outdated
Show resolved
Hide resolved
| focusedIndex: number | null; | ||
| resetTagFocus: () => void; | ||
| setTagIndex: (index: number | null) => void; | ||
| }; | ||
|
|
||
| type ComboboxContextType = ComboboxProp & { | ||
| filteredItems?: ComboboxItemOrGroup[]; |
packages/ods-react/src/components/combobox/src/contexts/useCombobox.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-control/ComboboxControl.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-control/ComboboxControl.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-control/ComboboxControl.tsx
Outdated
Show resolved
Hide resolved
…d clean up unused handlers
var-poro
force-pushed
the
ods-react-combobox-multiple
branch
from
546e412 to
a663bee
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
astagnol
reviewed
Jun 26, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
astagnol
requested changes
Jun 26, 2025
There was a problem hiding this comment.
With Voiceover, Combobox is recognized as a "list box pop-up, button", not a "list box pop-up, combo box" as it is in the original lib. It causes accessibility issues since when the user is typing, nothing is vocalized and the same goes for the list of options.
dpellier
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.