Skip to content

Commit 5521f76

Browse files
author
epriestley
committedJul 8, 2021
Remove some "Phacility" and "epriestley" references
Summary: Ref T13658. This just scrubs some of the simple references from the codebase. Most of what's left is in documentation which won't be relevant for a fork and/or which I need to separately revise (or more-or-less delete) at some point anyway. I removed the "install RHEL" and "install Ubuntu" scripts outright since I don't have any reasonable way to test them and don't plan to maintain them. Test Plan: Grepped for "phacility", "epriestley"; ran unit tests. Reviewers: cspeckmim Reviewed By: cspeckmim Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13658 Differential Revision: https://secure.phabricator.com/D21678
1 parent 14c516b commit 5521f76

19 files changed

+39
-305
lines changed
 

‎NOTICE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Phabricator
22
Copyright 2014 Phacility, Inc.
33

4-
This software is primarily developed and maintained by Phacility, Inc.
4+
Phabricator was originally developed and maintained by Phacility, Inc.
55

66
http://www.phacility.com/
77

‎resources/celerity/map.php

+10-10
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
'conpherence.pkg.css' => '0e3cf785',
1111
'conpherence.pkg.js' => '020aebcf',
1212
'core.pkg.css' => '0ae696de',
13-
'core.pkg.js' => '68f29322',
13+
'core.pkg.js' => 'd2de90d9',
1414
'dark-console.pkg.js' => '187792c2',
1515
'differential.pkg.css' => 'ffb69e3d',
1616
'differential.pkg.js' => '8deec4cd',
@@ -246,7 +246,7 @@
246246
'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => 'a9f35511',
247247
'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '3a1b81f6',
248248
'rsrc/externals/javelin/lib/Cookie.js' => '05d290ef',
249-
'rsrc/externals/javelin/lib/DOM.js' => '94681e22',
249+
'rsrc/externals/javelin/lib/DOM.js' => 'e4c7622a',
250250
'rsrc/externals/javelin/lib/History.js' => '030b4f7a',
251251
'rsrc/externals/javelin/lib/JSON.js' => '541f81c3',
252252
'rsrc/externals/javelin/lib/Leader.js' => '0d2490ce',
@@ -717,7 +717,7 @@
717717
'javelin-color' => '78f811c9',
718718
'javelin-cookie' => '05d290ef',
719719
'javelin-diffusion-locate-file-source' => '94243d89',
720-
'javelin-dom' => '94681e22',
720+
'javelin-dom' => 'e4c7622a',
721721
'javelin-dynval' => '202a2e85',
722722
'javelin-event' => 'c03f2fb4',
723723
'javelin-external-editor-link-engine' => '48a8641f',
@@ -1781,13 +1781,6 @@
17811781
'javelin-uri',
17821782
'javelin-routable',
17831783
),
1784-
'94681e22' => array(
1785-
'javelin-magical-init',
1786-
'javelin-install',
1787-
'javelin-util',
1788-
'javelin-vector',
1789-
'javelin-stratcom',
1790-
),
17911784
'9623adc1' => array(
17921785
'javelin-behavior',
17931786
'javelin-stratcom',
@@ -2167,6 +2160,13 @@
21672160
'javelin-dom',
21682161
'phuix-dropdown-menu',
21692162
),
2163+
'e4c7622a' => array(
2164+
'javelin-magical-init',
2165+
'javelin-install',
2166+
'javelin-util',
2167+
'javelin-vector',
2168+
'javelin-stratcom',
2169+
),
21702170
'e5bdb730' => array(
21712171
'javelin-behavior',
21722172
'javelin-stratcom',

‎resources/sql/patches/20131004.dxreviewers.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
foreach ($reviewer_phids as $dst) {
3030
if (phid_get_type($dst) == PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) {
3131
// At least one old install ran into some issues here. Skip the row if we
32-
// can't figure out what the destination PHID is. See here:
33-
// https://github.com/phacility/phabricator/pull/507
32+
// can't figure out what the destination PHID is.
3433
continue;
3534
}
3635

‎scripts/install/install_rhel-derivs.sh

-138
This file was deleted.

‎scripts/install/install_ubuntu.sh

-117
This file was deleted.

‎src/applications/almanac/util/__tests__/AlmanacNamesTestCase.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function testServiceOrDeviceNames() {
3030

3131
'abc' => true,
3232
'a.b' => true,
33-
'db.phacility.instance' => true,
33+
'db.companyname.instance' => true,
3434
'web002.useast.example.com' => true,
3535
'master.example-corp.com' => true,
3636

‎src/applications/base/PhabricatorApplication.php

+2-3
Original file line numberDiff line numberDiff line change
@@ -135,10 +135,9 @@ public function isPinnedByDefault(PhabricatorUser $viewer) {
135135

136136

137137
/**
138-
* Returns true if an application is first-party (developed by Phacility)
139-
* and false otherwise.
138+
* Returns true if an application is first-party and false otherwise.
140139
*
141-
* @return bool True if this application is developed by Phacility.
140+
* @return bool True if this application is first-party.
142141
*/
143142
final public function isFirstParty() {
144143
$where = id(new ReflectionClass($this))->getFileName();

‎src/applications/calendar/parser/ics/PhutilICSWriter.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,15 @@ private function getDocumentNodeProperties(
128128

129129
$properties[] = $this->newTextProperty(
130130
'PRODID',
131-
'-//Phacility//Phabricator//EN');
131+
self::getICSPRODID());
132132

133133
return $properties;
134134
}
135135

136+
public static function getICSPRODID() {
137+
return '-//Phacility//Phabricator//EN';
138+
}
139+
136140
private function getEventNodeProperties(PhutilCalendarEventNode $event) {
137141
$properties = array();
138142

‎src/applications/calendar/parser/ics/__tests__/PhutilICSWriterTestCase.php

+6
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,12 @@ private function writeICS(PhutilCalendarRootNode $root) {
138138
private function assertICS($name, $actual) {
139139
$path = dirname(__FILE__).'/data/'.$name;
140140
$data = Filesystem::readFile($path);
141+
142+
$data = str_replace(
143+
'${PRODID}',
144+
PhutilICSWriter::getICSPRODID(),
145+
$data);
146+
141147
$this->assertEqual($data, $actual, pht('ICS: %s', $name));
142148
}
143149

‎src/applications/calendar/parser/ics/__tests__/data/writer-christmas.ics

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
BEGIN:VCALENDAR
22
VERSION:2.0
3-
PRODID:-//Phacility//Phabricator//EN
3+
PRODID:${PRODID}
44
BEGIN:VEVENT
55
UID:christmas-day
66
CREATED:20160901T232425Z

‎src/applications/calendar/parser/ics/__tests__/data/writer-office-party.ics

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
BEGIN:VCALENDAR
22
VERSION:2.0
3-
PRODID:-//Phacility//Phabricator//EN
3+
PRODID:${PRODID}
44
BEGIN:VEVENT
55
UID:office-party
66
CREATED:20161001T120000Z

0 commit comments

Comments
 (0)
Failed to load comments.