Skip to content

Commit af6cc0c

Browse files
author
epriestley
committedJul 21, 2021
Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator
Summary: Ref T13660. Clean up callsites to "PhutilExecPassthru->execute()" to prepare to deprecate it. Test Plan: - Grepped for "PhutilExecPassthru" and looked for callsites. - Ran `GIT_SSH=.../ssh-connect git ls-remote origin` to execute the "ssh-connect" code. - The two passthru future methods have no callers and could possibly be removed, but I'm just letting sleeping dogs lie for now. Reviewers: cspeckmim Reviewed By: cspeckmim Maniphest Tasks: T13660 Differential Revision: https://secure.phabricator.com/D21703
1 parent 2f1acf8 commit af6cc0c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎scripts/ssh/ssh-connect.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,6 @@ function ssh_connect_signal($signo) {
154154
array_unshift($arguments, $pattern);
155155

156156
$err = newv('PhutilExecPassthru', $arguments)
157-
->execute();
157+
->resolve();
158158

159159
exit($err);

‎src/applications/repository/storage/PhabricatorRepository.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ public function getRemoteCommandFuture($pattern /* , $arg, ... */) {
499499

500500
public function passthruRemoteCommand($pattern /* , $arg, ... */) {
501501
$args = func_get_args();
502-
return $this->newRemoteCommandPassthru($args)->execute();
502+
return $this->newRemoteCommandPassthru($args)->resolve();
503503
}
504504

505505
private function newRemoteCommandFuture(array $argv) {
@@ -540,7 +540,7 @@ public function getLocalCommandFuture($pattern /* , $arg, ... */) {
540540

541541
public function passthruLocalCommand($pattern /* , $arg, ... */) {
542542
$args = func_get_args();
543-
return $this->newLocalCommandPassthru($args)->execute();
543+
return $this->newLocalCommandPassthru($args)->resolve();
544544
}
545545

546546
private function newLocalCommandFuture(array $argv) {

0 commit comments

Comments
 (0)
Failed to load comments.