Skip to content

Commit 0d16544

Browse files
Chad Littlechad
Chad Little
authored and
chad
committedJun 9, 2017
Clean up spacing on diff-banner
Summary: Adds spacing to the buttons, line-height for aligning text vertically. Test Plan: Leave comments on a diff. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18110
1 parent 3400f24 commit 0d16544

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed
 

‎resources/celerity/map.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
'core.pkg.css' => 'ab24402f',
1313
'core.pkg.js' => '1475bd91',
1414
'darkconsole.pkg.js' => '1f9a31bc',
15-
'differential.pkg.css' => '1ccbf3a9',
15+
'differential.pkg.css' => '4e99863c',
1616
'differential.pkg.js' => 'b7504037',
1717
'diffusion.pkg.css' => 'b93d9b8c',
1818
'diffusion.pkg.js' => '6134c5a1',
@@ -64,7 +64,7 @@
6464
'rsrc/css/application/dashboard/dashboard.css' => 'fe5b1869',
6565
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
6666
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
67-
'rsrc/css/application/differential/changeset-view.css' => 'c3f44655',
67+
'rsrc/css/application/differential/changeset-view.css' => 'c72dba88',
6868
'rsrc/css/application/differential/core.css' => '5b7b8ff4',
6969
'rsrc/css/application/differential/phui-inline-comment.css' => 'ffd1a542',
7070
'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
@@ -562,7 +562,7 @@
562562
'conpherence-thread-manager' => '4d863052',
563563
'conpherence-transaction-css' => '85129c68',
564564
'd3' => 'a11a5ff2',
565-
'differential-changeset-view-css' => 'c3f44655',
565+
'differential-changeset-view-css' => 'c72dba88',
566566
'differential-core-view-css' => '5b7b8ff4',
567567
'differential-revision-add-comment-css' => 'c47f8c40',
568568
'differential-revision-comment-css' => '14b8565a',
@@ -1872,9 +1872,6 @@
18721872
'javelin-dom',
18731873
'javelin-vector',
18741874
),
1875-
'c3f44655' => array(
1876-
'phui-inline-comment-view-css',
1877-
),
18781875
'c420b0b9' => array(
18791876
'javelin-behavior',
18801877
'javelin-behavior-device',
@@ -1896,6 +1893,9 @@
18961893
'javelin-stratcom',
18971894
'javelin-util',
18981895
),
1896+
'c72dba88' => array(
1897+
'phui-inline-comment-view-css',
1898+
),
18991899
'c7ccd872' => array(
19001900
'phui-fontkit-css',
19011901
),

‎webroot/rsrc/css/application/differential/changeset-view.css

+7-2
Original file line numberDiff line numberDiff line change
@@ -392,13 +392,14 @@ tr.differential-inline-loading {
392392
top: 0;
393393
left: 0;
394394
right: 0;
395-
background: rgba(255, 255, 255, 0.95);
395+
background: #fff;
396396
box-shadow: 0px 1px 3px rgba(0, 0, 0, 0.1);
397397
border-bottom: 1px solid {$lightgreyborder};
398-
padding: 12px 18px;
398+
padding: 8px 18px;
399399
vertical-align: middle;
400400
font-weight: bold;
401401
font-size: {$biggerfontsize};
402+
line-height: 28px;
402403
}
403404

404405
.diff-banner .phui-icon-view {
@@ -409,6 +410,10 @@ tr.differential-inline-loading {
409410
color: {$greytext};
410411
}
411412

413+
.diff-banner-buttons .button {
414+
margin-left: 8px;
415+
}
416+
412417
.diff-banner-has-unsaved,
413418
.diff-banner-has-unsubmitted {
414419
background: {$sh-yellowbackground};

0 commit comments

Comments
 (0)
Failed to load comments.