Skip to content

Commit dda06c6

Browse files
author
Josh Cox
committedSep 19, 2016
Added a 'name' field to the results for harbormaster.build.search endpoint
Summary: Fixes T11642. Added a 'name' field to the results from harbormaster.build.search. Test Plan: Went to `/conduit/method/harbormaster.build.search/` and ran a search that would yield results (because otherwise there will be nothing there). Noted that there was, in fact, a name in the results. Reviewers: yelirekim, #blessed_reviewers, epriestley Reviewed By: yelirekim, #blessed_reviewers, epriestley Subscribers: epriestley, yelirekim Maniphest Tasks: T11642 Differential Revision: https://secure.phabricator.com/D16569
1 parent 1afd8cb commit dda06c6

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed
 

‎src/applications/harbormaster/storage/build/HarbormasterBuild.php

+5
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,10 @@ public function getFieldSpecificationsForConduit() {
420420
->setKey('initiatorPHID')
421421
->setType('phid')
422422
->setDescription(pht('The person (or thing) that started this build.')),
423+
id(new PhabricatorConduitSearchFieldSpecification())
424+
->setKey('name')
425+
->setType('string')
426+
->setDescription(pht('The name of this build.')),
423427
);
424428
}
425429

@@ -433,6 +437,7 @@ public function getFieldValuesForConduit() {
433437
'name' => HarbormasterBuildStatus::getBuildStatusName($status),
434438
),
435439
'initiatorPHID' => nonempty($this->getInitiatorPHID(), null),
440+
'name' => $this->getName(),
436441
);
437442
}
438443

0 commit comments

Comments
 (0)
Failed to load comments.