Skip to content

Fix type resolution #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 27, 2025
Merged

Fix type resolution #662

merged 11 commits into from
Jun 27, 2025

Conversation

AdrianSosic
Copy link
Contributor

Fixes #661

@AdrianSosic AdrianSosic force-pushed the fix/type_resolution branch from 58ee5ae to 05d823b Compare June 26, 2025 10:56
AdrianSosic
AdrianSosic commented Jun 26, 2025
View reviewed changes
AdrianSosic
AdrianSosic commented Jun 26, 2025
View reviewed changes
@Tinche Tinche self-requested a review June 26, 2025 11:16
Tinche
Tinche requested changes Jun 26, 2025
View reviewed changes
Copy link
Member

@Tinche Tinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a small changelog entry.

AdrianSosic
AdrianSosic commented Jun 26, 2025
View reviewed changes
@Tinche Tinche self-requested a review June 26, 2025 14:55
Tinche
Tinche requested changes Jun 26, 2025
View reviewed changes
Copy link
Member

@Tinche Tinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please rename forwardrefs.py to something else, and add a period (.) to the end of the changelog entry ;)

AdrianSosic
AdrianSosic commented Jun 27, 2025
View reviewed changes
@AdrianSosic AdrianSosic force-pushed the fix/type_resolution branch from c5795ad to 414799b Compare June 27, 2025 08:01
@AdrianSosic AdrianSosic requested a review from Tinche June 27, 2025 08:30
Tinche
Tinche approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@Tinche Tinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ as usual

@Tinche Tinche merged commit 30fb43e into python-attrs:main Jun 27, 2025
11 checks passed
@AdrianSosic AdrianSosic deleted the fix/type_resolution branch June 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tinche Tinche Tinche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unresolved generic types
2 participants
@AdrianSosic @Tinche