gh-134986: Catch PermissionError when trying to call perf in tests #134987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a `PermissionError` instead of `FileNotFoundError`. This commit modifies the tests to catch that.
emmatyping
added
skip news
needs backport to 3.13
terryjreedy
reviewed
May 31, 2025
itamaro
approved these changes
Jun 22, 2025
|
Thanks @emmatyping for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 23, 2025
…sts (pythonGH-134987) Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a `PermissionError` instead of `FileNotFoundError`. This commit modifies the tests to catch that. (cherry picked from commit 6ab842f) Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
GH-135841 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 23, 2025
…sts (pythonGH-134987) Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a `PermissionError` instead of `FileNotFoundError`. This commit modifies the tests to catch that. (cherry picked from commit 6ab842f) Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
GH-135842 is a backport of this pull request to the 3.13 branch. |
|
Merged, thank you. |
vstinner
pushed a commit
that referenced
this pull request
Jun 23, 2025
…ests (GH-134987) (#135842) gh-134986: Catch PermissionError when trying to call perf in tests (GH-134987) Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a `PermissionError` instead of `FileNotFoundError`. This commit modifies the tests to catch that. (cherry picked from commit 6ab842f) Co-authored-by: Emma Smith <emma@emmatyping.dev>
vstinner
pushed a commit
that referenced
this pull request
Jun 23, 2025
…ests (GH-134987) (#135841) gh-134986: Catch PermissionError when trying to call perf in tests (GH-134987) Using Ubuntu 24.04 on the Windows Subsystem for Linux, perf will raise a `PermissionError` instead of `FileNotFoundError`. This commit modifies the tests to catch that. (cherry picked from commit 6ab842f) Co-authored-by: Emma Smith <emma@emmatyping.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Ubuntu 24.04 on the Windows Subsystem for Linux,
perfwill raise aPermissionErrorinstead ofFileNotFoundErrorwhen it is missing. This PR modifies the tests to catch that.test_perf_profilerfails under Windows Subsystem for Linux #134986