gh-135768: fix allowed/blocked IPv6 domains in `http.cookiejar` #135771

LamentXU123 · 2025-06-20T17:00:47Z

PR for #135768, Thanks!

Issue: Correctly block＆allow IPv6 domains in http.cookiejar #135768

picnixz

Please add tests.

Lib/http/cookiejar.py

bedevere-app · 2025-06-20T17:15:56Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Lib/http/cookiejar.py

Misc/NEWS.d/next/Library/2025-06-20-17-03-51.gh-issue-135768.DhUJWf.rst

…hUJWf.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Lib/http/cookiejar.py

LamentXU123 · 2025-06-20T18:18:08Z

Please add tests.

Done.

Lib/http/cookiejar.py

Lib/test/test_http_cookiejar.py

Lib/http/cookiejar.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

LamentXU123 · 2025-06-22T15:04:13Z

The helper functions will help a lot in the future PRs I think.

picnixz

last nits and we're done

Lib/http/cookiejar.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

LamentXU123 · 2025-06-22T15:06:58Z

last nits and we're done

Thanks! This is my first time ever to create a PR for Cpython with nearly a hundred lines of code. Thank you for your patience and guidence!

picnixz

I'm mostly good but I'll ask another expert just in case @vadmium.

Lib/http/cookiejar.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

LamentXU123 · 2025-06-22T15:15:07Z

I'm mostly good but I'll ask another expert just in case @vadmium.

May I close the issue? I think its mostly solved.

picnixz · 2025-06-22T15:19:05Z

No, we should never close an issue until the corresponding PR has been merged or we abandoned the proposal. In this case, closing the issue means that both the PR and its backports have been merged.

LamentXU123 · 2025-06-22T15:20:35Z

No, we should never close an issue until the corresponding PR has been merged or we abandoned the proposal. In this case, closing the issue means that both the PR and its backports have been merged.

Got it!

LamentXU123 · 2025-06-23T14:34:09Z

I will also add warnings in docs indicating ::1 in not valid when they are blocking or allowing hostname after this is merged, also, remove the duplicated tests in another PR. IPv6 appears to be an edge case in many functions of http.cookiejar, I'll try to fix them one by one in the future.

LamentXU123 · 2025-06-24T09:49:38Z

Hi @picnixz, friendly pinging here. Shell we get this PR merged? caz I can't contribute to further following PRs and issues if this is not merged. TiA ;) (I think it is mostly solved, and tiny fixes can be coped later, if any.)

picnixz · 2025-06-24T09:57:17Z

No. I want to hear from Martin first. PRs don't need to be rushed and it's common to have PRs landing after a few weeks.

You can still contribute to other parts of the library (which I would advise you to do so).

Update cookiejar.py

e3cfeb6

bedevere-app bot added the awaiting review label Jun 20, 2025

bedevere-app bot mentioned this pull request Jun 20, 2025

Correctly block＆allow IPv6 domains in http.cookiejar #135768

Open

blurb-it bot and others added 4 commits June 20, 2025 17:03

📜🤖 Added by blurb_it.

8c5320a

Update 2025-06-20-17-03-51.gh-issue-135768.DhUJWf.rst

4c452f9

Update 2025-06-20-17-03-51.gh-issue-135768.DhUJWf.rst

60304ce

Update 2025-06-20-17-03-51.gh-issue-135768.DhUJWf.rst

714d4d8

picnixz requested changes Jun 20, 2025

View reviewed changes

bedevere-app bot added awaiting changes and removed awaiting review labels Jun 20, 2025

LamentXU123 and others added 5 commits June 21, 2025 01:19

Update Lib/http/cookiejar.py

4c9ab02

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/cookiejar.py

2c9f6a4

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/cookiejar.py

a5198ee

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/cookiejar.py

baf62d1

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update cookiejar.py

0783fc1

picnixz reviewed Jun 20, 2025

View reviewed changes

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

picnixz reviewed Jun 20, 2025

View reviewed changes

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

add IPV6 regex

dffb204

picnixz reviewed Jun 20, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-06-20-17-03-51.gh-issue-135768.DhUJWf.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2025-06-20-17-03-51.gh-issue-135768.D…

056b44d

…hUJWf.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz reviewed Jun 20, 2025

View reviewed changes

Lib/http/cookiejar.py Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

picnixz changed the title ~~gh-135768: Support IPv6 in http.cookiejar~~ gh-135768: fix allowed/blocked IPv6 domains in http.cookiejar Jun 20, 2025

LamentXU123 added 4 commits June 21, 2025 01:41

add string method instead of regex to detect IPV6

37c1933

update is_ip

779e443

update comments

1c00c39

Update test_http_cookiejar.py

4c12cec

LamentXU123 requested a review from picnixz June 20, 2025 18:18

picnixz reviewed Jun 20, 2025

View reviewed changes

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/test/test_http_cookiejar.py Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Update cookiejar.py

7b6feea

LamentXU123 requested a review from picnixz June 22, 2025 14:34

LamentXU123 added 2 commits June 22, 2025 22:35

Update cookiejar.py

1fd504b

Update cookiejar.py

6238901

picnixz reviewed Jun 22, 2025

View reviewed changes

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

LamentXU123 and others added 3 commits June 22, 2025 22:48

Update Lib/http/cookiejar.py

aef5edf

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/cookiejar.py

c5a1be2

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update cookiejar.py

e3b6a1c

picnixz reviewed Jun 22, 2025

View reviewed changes

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

LamentXU123 and others added 2 commits June 22, 2025 23:05

Update Lib/http/cookiejar.py

e37015c

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/http/cookiejar.py

36cb03b

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz added awaiting core review and removed awaiting change review labels Jun 22, 2025

picnixz added awaiting review and removed awaiting core review labels Jun 22, 2025

Merge branch 'main' into support-IPv6-in-cookiejar

6fe7c76

picnixz approved these changes Jun 22, 2025

View reviewed changes

Lib/http/cookiejar.py Outdated Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting review labels Jun 22, 2025

Update Lib/http/cookiejar.py

e7e1d83

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Merge branch 'main' into support-IPv6-in-cookiejar

3cea83c

picnixz requested a review from vadmium June 24, 2025 12:07

Uh oh!

gh-135768: fix allowed/blocked IPv6 domains in http.cookiejar #135771

Are you sure you want to change the base?

gh-135768: fix allowed/blocked IPv6 domains in http.cookiejar #135771

Conversation

LamentXU123 commented Jun 20, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LamentXU123 commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LamentXU123 commented Jun 22, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LamentXU123 commented Jun 22, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LamentXU123 commented Jun 22, 2025

Uh oh!

picnixz commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LamentXU123 commented Jun 22, 2025

Uh oh!

LamentXU123 commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LamentXU123 commented Jun 24, 2025

Uh oh!

picnixz commented Jun 24, 2025

Uh oh!

Uh oh!

gh-135768: fix allowed/blocked IPv6 domains in `http.cookiejar` #135771

gh-135768: fix allowed/blocked IPv6 domains in `http.cookiejar` #135771

LamentXU123 commented Jun 20, 2025 •

edited by bedevere-app bot

Loading

picnixz commented Jun 22, 2025 •

edited

Loading

LamentXU123 commented Jun 23, 2025 •

edited

Loading