gh-135528: Support more second-level domain names in http.cookiejar #135820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
changed the title
auvipy
suggested changes
Jun 25, 2025
| "gov", "mil", "int", "aero", "biz", "cat", "coop", | ||
| "info", "jobs", "mobi", "museum", "name", "pro", | ||
| "travel", "eu") and len(tld) == 2: | ||
| known_slds = ( |
There was a problem hiding this comment.
should we also add tests for the newly added sld's?
There was a problem hiding this comment.
No need IMO, the original test script only test .co.uk for this.
There was a problem hiding this comment.
sry to miss that, it actually test [".co.uk", ".org.za", ".tx.us", ".name.us"] but it's just four of them, I think it's still no need to add tests.
auvipy
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to reopen it. I want to support customization in this. But since the FR has not discussed before, its not proper to directly create PR on this. I should treat this seperately. Just forget about the previous FR.
This PR only concerns of adding new common slds in the lib based on wiki figure, as its been a very long time from 2006 when the list is wrote.
So sorry for reopening this.