Skip to content

gh-135839: Fix traverse_module_state usage in _interpchannelsmodule #135840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2025
Merged

gh-135839: Fix traverse_module_state usage in _interpchannelsmodule #135840

merged 2 commits into from
Jun 25, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 23, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 23, 2025
Closed
vstinner
vstinner approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ericsnowcurrently
ericsnowcurrently approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn merged commit dd59c78 into python:main Jun 25, 2025
69 of 71 checks passed
@sobolevn sobolevn added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker dd59c786cfb1018eb5abe877bfa7265ea9a3c2b9 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2025
@sobolevn @miss-islington
pythongh-135839: Fix module_traverse and module_clear in `_interp…
279dc7d 
…channelsmodule` (pythonGH-135840)

(cherry picked from commit dd59c78)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jun 25, 2025

GH-135918 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 25, 2025

GH-135919 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 25, 2025
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jun 25, 2025
@sobolevn
[3.13] pythongh-135839: Fix module_traverse and module_clear in `…
0f085e2 
…_interpchannelsmodule` (pythonGH-135840)

(cherry picked from commit dd59c78)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jun 25, 2025
@sobolevn
[3.13] pythongh-135839: Fix module_traverse and module_clear in `…
8c63261 
…_interpchannelsmodule` (pythonGH-135840)

(cherry picked from commit dd59c78)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 25, 2025
@miss-islington @sobolevn
[3.14] gh-135839: Fix module_traverse and module_clear in `_inter…
93a31be 
…pchannelsmodule` (GH-135840) (#135918)

gh-135839: Fix `module_traverse` and `module_clear` in `_interpchannelsmodule` (GH-135840)
(cherry picked from commit dd59c78)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Jun 25, 2025
@sobolevn
[3.13] gh-135839: Fix module_traverse and module_clear in `_inter…
28c5adf 
…pchannelsmodule` (GH-135840) (#135919)

(cherry picked from commit dd59c78)
@sobolevn sobolevn mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

@sobolevn sobolevn

Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @vstinner @ericsnowcurrently