Skip to content

gh-135755: Use private names (_Py*) for header file guards new in 3.14 #135921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 25, 2025

These are private; let's name new ones accordingly.

…in 3.14

These are private API; let's name new ones accordingly.
@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
38 tasks
@encukou encukou added skip news needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@encukou encukou merged commit 6be17ba into python:main Jun 26, 2025
45 checks passed
@encukou encukou deleted the private-header-guards branch June 26, 2025 11:05
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
(cherry picked from commit 6be17ba)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2025

GH-135976 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant