Skip to content

gh-135755: Move PyFunction_GET_BUILTINS to the private API #135938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

gh-135755: Move PyFunction_GET_BUILTINS to the private API #135938

merged 1 commit into from
Jun 26, 2025

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Jun 25, 2025 •
edited by bedevere-app bot
Loading

This is an alternative to GH-135934. It seems like it might be better to move this to the private API for a few reasons:

  1. There's no PyFunction_Get* equivalent for PyFunction_GET_BUILTINS.
  2. It's mostly untested, the only reference to it in the tests being in _testinternalcapi.

@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
39 tasks
ericsnowcurrently
ericsnowcurrently approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, making it internal makes sense.

encukou
encukou approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou encukou merged commit 10a3d43 into python:main Jun 26, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@ZeroIntensity @miss-islington
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
e582c8b 
…ythonGH-135938)

(cherry picked from commit 10a3d43)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 26, 2025

GH-135972 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@encukou encukou mentioned this pull request Jun 26, 2025
Closed
encukou pushed a commit that referenced this pull request Jun 26, 2025
@miss-islington @ZeroIntensity
[3.14] gh-135755: Move PyFunction_GET_BUILTINS to the private API (G…
a797fe1 
…H-135938) (GH-135972)

(cherry picked from commit 10a3d43)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@ZeroIntensity @AndPuQing
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
55e0336 
…ythonGH-135938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news topic-C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeroIntensity @encukou @ericsnowcurrently