gh-135968: Add iOS binary stubs for strip #135970
Conversation
freakboy3742
added
OS-ios
needs backport to 3.13
| @@ -0,0 +1,2 @@ | |||
| #!/bin/sh | |||
| xcrun --sdk iphonesimulator${IOS_SDK_VERSION} strip -arch arm64 "$@" | |||
There was a problem hiding this comment.
The return value from xcrun / the underlying command isn't returned to the caller for these as written. Either -e option (errexit) to /bin/sh and/or using exec to run the subcommand should resolve; not sure which is best practice.
There was a problem hiding this comment.
@cmaloney Are you sure about that? From my testing:
$ iOS/Resources/bin/arm64-apple-ios-simulator-clang -c hello.c -o hello
$ echo $?
0
$ iOS/Resources/bin/arm64-apple-ios-simulator-clang
clang: error: no input files
$ echo $?
1
Or am I missing something here?
There was a problem hiding this comment.
set -e or equivalent would only be needed if there were another command following the xcrun, no? Otherwise, the stub script will exit with the status of the last executed command, that is, the command executed by xcrun.
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Adds iOS binary stubs for invoking `strip` (cherry picked from commit 0c6c09b) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Adds iOS binary stubs for invoking `strip` (cherry picked from commit 0c6c09b) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
GH-136014 is a backport of this pull request to the 3.14 branch. |
|
GH-136015 is a backport of this pull request to the 3.13 branch. |
Adds iOS binary stubs for strip.
This is something that came up in the development of a port of
numpy; Meson looks forstripby default, and raises a warning if it can't be found. It's easy enough to provide the stub to avoid the warning.strip#135968