Skip to content

gh-136288: Correct error display in _testcapi/vectorcall.c #136258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

gh-136288: Correct error display in _testcapi/vectorcall.c #136258

merged 2 commits into from
Jul 4, 2025

Conversation

wsfulton
Copy link
Contributor

@wsfulton wsfulton commented Jul 3, 2025 •
edited by bedevere-app bot
Loading

Correct incorrect conversion specifier in test from %s to %S for PyObject *. I could have added a test, but that would be testing the test!

@python-cla-bot
Copy link

python-cla-bot bot commented Jul 3, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

STc058

This comment was marked as spam.

Sign in to view

ZeroIntensity
ZeroIntensity reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an issue for posterity.

@ZeroIntensity ZeroIntensity added tests Tests in the Lib/test dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news labels Jul 4, 2025
@wsfulton
Correct error display in _testcapi/vectorcall.c
d324884 
Use %N instead of %S and PyType_GetName.
@ZeroIntensity ZeroIntensity mentioned this pull request Jul 4, 2025
Closed
@ZeroIntensity ZeroIntensity changed the title Correct error display in _testcapi/vectorcall.c gh-136288: Correct error display in _testcapi/vectorcall.c Jul 4, 2025
ZeroIntensity
ZeroIntensity approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I've created gh-136288 and attached it to the PR for you.

vstinner
vstinner approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity ZeroIntensity merged commit d1d5dce into python:main Jul 4, 2025
73 of 75 checks passed
@miss-islington-app
Copy link

Thanks @wsfulton for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2025
@wsfulton @miss-islington
pythongh-136288: Fix error message in _testcapi/vectorcall.c (pytho…
9aa509a 
…nGH-136258)

Use the %N format specifier instead of %s and `PyType_GetName`.
(cherry picked from commit d1d5dce)

Co-authored-by: William S Fulton <wsf@fultondesigns.co.uk>
@bedevere-app
Copy link

bedevere-app bot commented Jul 4, 2025

GH-136294 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2025
@wsfulton @miss-islington
pythongh-136288: Fix error message in _testcapi/vectorcall.c (pytho…
f652526 
…nGH-136258)

Use the %N format specifier instead of %s and `PyType_GetName`.
(cherry picked from commit d1d5dce)

Co-authored-by: William S Fulton <wsf@fultondesigns.co.uk>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 4, 2025

GH-136295 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 4, 2025
ZeroIntensity pushed a commit that referenced this pull request Jul 4, 2025
@miss-islington @wsfulton
[3.13] gh-136288: Fix error message in _testcapi/vectorcall.c (GH-1…
a717ed9 
…36258) (GH-136295)

gh-136288: Fix error message in `_testcapi/vectorcall.c` (GH-136258)

Use the %N format specifier instead of %s and `PyType_GetName`.
(cherry picked from commit d1d5dce)

Co-authored-by: William S Fulton <wsf@fultondesigns.co.uk>
ZeroIntensity pushed a commit that referenced this pull request Jul 4, 2025
@miss-islington @wsfulton
[3.14] gh-136288: Fix error message in _testcapi/vectorcall.c (GH-1…
6d21cc5 
…36258) (GH-136294)

gh-136288: Fix error message in `_testcapi/vectorcall.c` (GH-136258)

Use the %N format specifier instead of %s and `PyType_GetName`.
(cherry picked from commit d1d5dce)

Co-authored-by: William S Fulton <wsf@fultondesigns.co.uk>
@wsfulton wsfulton deleted the vectorcall-test branch July 4, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STc058 STc058 STc058 requested changes

@vstinner vstinner vstinner approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wsfulton @vstinner @ZeroIntensity @STc058