Skip to content

Move or outside monospace syntax in tarfile.rst #136263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Move or outside monospace syntax in tarfile.rst #136263

merged 1 commit into from
Jul 4, 2025

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Jul 4, 2025 •
edited by github-actions bot
Loading

Using "or" inside the monospace syntax gives the impression it is a OR operator and, therefore, should not be translated by doc translation teams. I understand correctly, it is not a logical operator.

📚 Documentation preview 📚: https://cpython-previews--136263.org.readthedocs.build/

@rffontenelle rffontenelle requested a review from ethanfurman as a code owner July 4, 2025 01:42
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 4, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jul 4, 2025
StanFromIreland
StanFromIreland approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

They could also be replaced with commas instead?

ZeroIntensity
ZeroIntensity approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think "or" is fine and clear. We can switch to commas if there's ever more than two entries.

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 4, 2025
@ZeroIntensity ZeroIntensity merged commit ade1988 into python:main Jul 4, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 4, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2025
@rffontenelle @miss-islington
Docs: Move "or" outside monospace syntax in tarfile.rst (pythonGH-1…
cc0e90c 
…36263)

(cherry picked from commit ade1988)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry, @rffontenelle and @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ade19880943509945da193202ca89e0b2b6fbd75 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jul 4, 2025

GH-136290 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 4, 2025
@ZeroIntensity
Copy link
Member

@rffontenelle Would you like to make the 3.13 backport?

ZeroIntensity pushed a commit that referenced this pull request Jul 4, 2025
@miss-islington @rffontenelle
[3.14] Docs: Move "or" outside monospace syntax in tarfile.rst (GH-…
1a2898a 
…136263) (GH-136290)

Docs: Move "or" outside monospace syntax in `tarfile.rst` (GH-136263)
(cherry picked from commit ade1988)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136348 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 7, 2025
ZeroIntensity pushed a commit that referenced this pull request Jul 7, 2025
@rffontenelle
[3.13] Docs: Move "or" outside monospace syntax in tarfile.rst (GH-13…
bc3390c 
…6263) (GH-136348)

Docs: Move "or" outside monospace syntax in `tarfile.rst` (GH-136263)

(cherry picked from commit ade1988)
@rffontenelle rffontenelle deleted the patch-6 branch July 7, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@ZeroIntensity ZeroIntensity

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rffontenelle @ZeroIntensity @StanFromIreland