Skip to content

gh-131825: Fixed sqlite timezone-naive adapter recipe #136270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

gh-131825: Fixed sqlite timezone-naive adapter recipe #136270

merged 1 commit into from
Jul 9, 2025

Conversation

NekrodNIK
Copy link
Contributor

@NekrodNIK NekrodNIK commented Jul 4, 2025 •
edited
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented Jul 4, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jul 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 4, 2025
Closed
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jul 4, 2025
@NekrodNIK NekrodNIK marked this pull request as ready for review July 4, 2025 06:56
StanFromIreland
StanFromIreland approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 9, 2025
ZeroIntensity
ZeroIntensity approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ZeroIntensity ZeroIntensity merged commit 6a6cd3c into python:main Jul 9, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 9, 2025
@miss-islington-app
Copy link

Thanks @NekrodNIK for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@NekrodNIK @miss-islington
pythongh-131825: Fix sqlite3 timezone-naive adapter recipe (pythonG…
d675de7 
…H-136270)

(cherry picked from commit 6a6cd3c)

Co-authored-by: NekrodNIK <60639354+NekrodNIK@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136467 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@NekrodNIK @miss-islington
pythongh-131825: Fix sqlite3 timezone-naive adapter recipe (pythonG…
d6eabcd 
…H-136270)

(cherry picked from commit 6a6cd3c)

Co-authored-by: NekrodNIK <60639354+NekrodNIK@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136468 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 9, 2025
ZeroIntensity pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @NekrodNIK
[3.14] gh-131825: Fix sqlite3 timezone-naive adapter recipe (GH-136270
75640d4 
) (GH-136467)

gh-131825: Fix `sqlite3` timezone-naive adapter recipe (GH-136270)
(cherry picked from commit 6a6cd3c)

Co-authored-by: NekrodNIK <60639354+NekrodNIK@users.noreply.github.com>
ZeroIntensity pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @NekrodNIK
[3.13] gh-131825: Fix sqlite3 timezone-naive adapter recipe (GH-136270
2176385 
) (GH-136468)

gh-131825: Fix `sqlite3` timezone-naive adapter recipe (GH-136270)
(cherry picked from commit 6a6cd3c)

Co-authored-by: NekrodNIK <60639354+NekrodNIK@users.noreply.github.com>
@ZeroIntensity
Copy link
Member

Congrats on your first contribution @NekrodNIK!

@StanFromIreland
Copy link
Member

Congratulations! I hope this won't be your last! You can filter by the "easy" label to get nice issues. I also suggest you look into the devguide it contains many useful tips and guides.

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@NekrodNIK @AndPuQing
pythongh-131825: Fix sqlite3 timezone-naive adapter recipe (pythonG…
978b416 
…H-136270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NekrodNIK @ZeroIntensity @StanFromIreland