gh-136300: Modify C tests to conform to PEP-737 #136301
Open
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use %T format specifier instead of %s and Py_TYPE(x)->tp_name. - Remove legacy %.200s format specifier for truncating type names.
vstinner
reviewed
Jul 8, 2025
Comment on lines
+1858
to
+1859
| "cannot index memory using \"%T\"", | ||
| key); |
There was a problem hiding this comment.
Suggested change
| "cannot index memory using \"%T\"", | |
| key); | |
| "cannot index memory using \"%T\"", key); |
Comment on lines
+8
to
+9
| PyErr_Format(PyExc_TypeError, "expect int, got %T", | ||
| obj); |
There was a problem hiding this comment.
Suggested change
| PyErr_Format(PyExc_TypeError, "expect int, got %T", | |
| obj); | |
| PyErr_Format(PyExc_TypeError, "expect int, got %T", obj); |
Comment on lines
+518
to
+519
| PyErr_Format(PyExc_TypeError, "'%T' object is not callable", | ||
| fn); |
There was a problem hiding this comment.
Suggested change
| PyErr_Format(PyExc_TypeError, "'%T' object is not callable", | |
| fn); | |
| PyErr_Format(PyExc_TypeError, "'%T' object is not callable", fn); |
Comment on lines
+2210
to
+2211
| PyExc_TypeError, "expected function or code object, got %T", | ||
| obj); |
There was a problem hiding this comment.
Suggested change
| PyExc_TypeError, "expected function or code object, got %T", | |
| obj); | |
| PyExc_TypeError, "expected function or code object, got %T", obj); |
vstinner
changed the title
The PEP is clear that it only affects new code:
But I'm fine with this very specific change which only changes C tests. There is no risk of backward compatibility issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.