gh-136315: Fix skipped multithreading test in test_zstd #136320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rogdham
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
Thank you for the fix!
I can confirm that the test is now run:
$ ./python -c 'from compression.zstd import *; print(CompressionParameter.nb_workers.bounds() != (0, 0))'
True
$ ./python -m test.test_zstd -k test_zstd_multithread_compress -v
test_zstd_multithread_compress (__main__.CompressorTestCase.test_zstd_multithread_compress) ... ok
----------------------------------------------------------------------
Ran 1 test in 0.229s
OK
gpshead
approved these changes
Jul 5, 2025
|
Thanks @emmatyping for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2025
…GH-136320) Fix skipped test in test_zstd (cherry picked from commit 5dac137) Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
GH-136322 is a backport of this pull request to the 3.14 branch. |
gpshead
pushed a commit
that referenced
this pull request
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Rogdham for spotting this one.