Skip to content

Commit 7daaaa8

Browse files
author
epriestley
committedSep 4, 2020
Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer
Summary: Ref T13579. This property was removed in D21425, but I missed this usage site. Remove the assignment; this class no longer tracks the subprocess PID directly. Test Plan: Searched for "->pid", no further hits. Maniphest Tasks: T13579 Differential Revision: https://secure.phabricator.com/D21452
1 parent 0854425 commit 7daaaa8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed
 

‎src/infrastructure/daemon/PhutilDaemonHandle.php

-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ private function annihilateProcessGroup() {
356356
posix_kill(-$pgid, SIGTERM);
357357
sleep($this->getKillDelay());
358358
posix_kill(-$pgid, SIGKILL);
359-
$this->pid = null;
360359
}
361360
}
362361
}

0 commit comments

Comments
 (0)
Failed to load comments.