-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[ISSUE-3402]: Ring.Pipelined return dial timeout error #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@smnvdev thank you for your contribution, I hope @monkey92t or @vmihailenco can review this, If not we will review it when possible, but Ring is not our main priority at the moment, just letting you know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses the dial timeout error issue for the Ring.Pipelined method by adding a new test case and adjusting the pipeline processing logic.
- Adds a test in ring_test.go to ensure a dial timeout error is returned when an invalid address is provided with a low dial timeout.
- Modifies the pipeline processing in ring.go to correctly handle transactional pipelines using a distinct hook assignment.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ring_test.go | New test case to check dial timeout errors in the pipeline function. |
ring.go | Updates to pipeline processing including refined hook assignment. |
Comments suppressed due to low confidence (1)
ring_test.go:293
- [nitpick] Consider enhancing the test by asserting that the error is specifically a dial timeout error rather than any error, to ensure the test accurately verifies the intended behavior.
Expect(err).To(HaveOccurred())
#3402