Skip to content

Commit fd3e7a9

Browse files
committed
Adjust cardinality of internal inliner thresholds
Summary: While compiling openJDK11 (also other workloads), some make files would pass both CFLAGS and LDFLAGS at link step ; resulting in duplicate options on the command line when one is using LTO and trying to influence the inliner. Most of the internal flags are ZeroOrMore, this diff changes the remaining ones. Reviewers: david2050, twoh, modocache Reviewed By: twoh Subscribers: mehdi_amini, dexonsmith, eraman, haicheng, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D57537 Patch by: Abdoul-Kader Keita llvm-svn: 353071
1 parent 8ea72a8 commit fd3e7a9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

llvm/lib/Analysis/InlineCost.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,19 @@ static cl::opt<int> InlineThreshold(
5050
cl::desc("Control the amount of inlining to perform (default = 225)"));
5151

5252
static cl::opt<int> HintThreshold(
53-
"inlinehint-threshold", cl::Hidden, cl::init(325),
53+
"inlinehint-threshold", cl::Hidden, cl::init(325), cl::ZeroOrMore,
5454
cl::desc("Threshold for inlining functions with inline hint"));
5555

5656
static cl::opt<int>
5757
ColdCallSiteThreshold("inline-cold-callsite-threshold", cl::Hidden,
58-
cl::init(45),
58+
cl::init(45), cl::ZeroOrMore,
5959
cl::desc("Threshold for inlining cold callsites"));
6060

6161
// We introduce this threshold to help performance of instrumentation based
6262
// PGO before we actually hook up inliner with analysis passes such as BPI and
6363
// BFI.
6464
static cl::opt<int> ColdThreshold(
65-
"inlinecold-threshold", cl::Hidden, cl::init(45),
65+
"inlinecold-threshold", cl::Hidden, cl::init(45), cl::ZeroOrMore,
6666
cl::desc("Threshold for inlining functions with cold attribute"));
6767

6868
static cl::opt<int>
@@ -87,7 +87,7 @@ static cl::opt<int> HotCallSiteRelFreq(
8787
"profile information."));
8888

8989
static cl::opt<bool> OptComputeFullInlineCost(
90-
"inline-cost-full", cl::Hidden, cl::init(false),
90+
"inline-cost-full", cl::Hidden, cl::init(false), cl::ZeroOrMore,
9191
cl::desc("Compute the full inline cost of a call site even when the cost "
9292
"exceeds the threshold."));
9393

0 commit comments

Comments
 (0)