Version bump

    - Fix jhamlet#15: No need to eval single attribute.
    - Loader utils already JSON parses the query string for us.
    - New test for JSON query strings

Author: jhamlet

index.js

@@ -75,19 +75,12 @@ module.exports = function (source) {
     var displayName = params.name || getName(rsrcPath);
     var tag         = params.tag || null;
     var reactDom    = params.reactDom || 'react-dom';
-    var attrs       = {};
-
-    if (params.attrs) {
-        // easier than having to write json in the query
-        // if anyone wants to exploit it, it's their build process
-        /*eslint no-eval:0*/
-        eval('assign(attrs, ' + params.attrs + ');');
-    }
+    var attrs       = assign({}, params.attrs || {});
 
     var opts = {
-        reactDom: reactDom,
-        tagName: tag,
-        attrs: attrs,
+        reactDom:    reactDom,
+        tagName:     tag,
+        attrs:       attrs,
         displayName: displayName
     };
 

package.json

@@ -2,7 +2,7 @@
     "name": "svg-react-loader",
     "fullname": "SVG to React Loader",
     "description": "A Webpack Loader to turn SVGs into React Components",
-    "version": "0.3.2",
+    "version": "0.3.3",
     "keywords": [
         "webpack",
         "loader",

test/test-test.js

@@ -1,6 +1,6 @@
 /*globals describe, it*/
 var react  = require('react');
-var loader = require('svg-react-loader');
+var loader = require('../');
 var babel  = require('babel-core');
 var fs     = require('fs');
 var path   = require('path');
@@ -33,7 +33,7 @@ function read (filepath) {
     return fs.readFileSync(path.join(__dirname, filepath), 'utf8');
 }
 
-describe('something', function () {
+describe('svg-react-loader', function () {
     it('should return a function', function () {
         loader.should.be.a.function;
     });
@@ -113,4 +113,28 @@ describe('something', function () {
             resourcePath: filename
         });
     });
+
+    it('json query', function (done) {
+        var filename = './svg/text.svg';
+
+        invoke(read(filename), {
+            callback: function (/*error, result*/) {
+                done();
+            },
+            query: '?' + JSON.stringify({
+                attrs: {
+                    style: {},
+                    width: 'auto',
+                    height: 'auto'
+                }
+            }),
+            resourceQuery: '?' + JSON.stringify({
+                attrs: {
+                    style: {},
+                    width: 'auto',
+                    height: 'auto'
+                }
+            })
+        });
+    });
 });