Skip to content

Commit 0e1042d

Browse files
committed
Fix Column Edit URI, simple dropdown UI
Summary: Fix the URL to editing columns, fix the color of a PHUIX dropdown(simple) Test Plan: Click on Dropdown, don't feel offended. Edit a Column from various search URLs. Fixes T5341 Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5341 Differential Revision: https://secure.phabricator.com/D9507
1 parent 933c631 commit 0e1042d

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

resources/celerity/map.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
return array(
88
'names' =>
99
array(
10-
'core.pkg.css' => 'c76b553b',
10+
'core.pkg.css' => '3a40ccda',
1111
'core.pkg.js' => '8335fe3f',
1212
'darkconsole.pkg.js' => 'ca8671ce',
1313
'differential.pkg.css' => '4a93db37',
@@ -123,7 +123,7 @@
123123
'rsrc/css/phui/calendar/phui-calendar-month.css' => 'a92e47d2',
124124
'rsrc/css/phui/calendar/phui-calendar.css' => '5e1ad989',
125125
'rsrc/css/phui/phui-box.css' => '7b3a2eed',
126-
'rsrc/css/phui/phui-button.css' => '1c771ff8',
126+
'rsrc/css/phui/phui-button.css' => 'c7412aa1',
127127
'rsrc/css/phui/phui-document.css' => 'a5615198',
128128
'rsrc/css/phui/phui-feed-story.css' => 'e2c9bc83',
129129
'rsrc/css/phui/phui-fontkit.css' => 'de84aa4a',
@@ -747,7 +747,7 @@
747747
'phrequent-css' => 'ffc185ad',
748748
'phriction-document-css' => '7d7f0071',
749749
'phui-box-css' => '7b3a2eed',
750-
'phui-button-css' => '1c771ff8',
750+
'phui-button-css' => 'c7412aa1',
751751
'phui-calendar-css' => '5e1ad989',
752752
'phui-calendar-day-css' => 'de035c8a',
753753
'phui-calendar-list-css' => 'c1d0ca59',

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ public function processRequest() {
162162
->setHeader($column->getDisplayName())
163163
->setHeaderColor($column->getHeaderColor());
164164
if (!$column->isDefaultColumn()) {
165-
$panel->setEditURI('column/'.$column->getID().'/');
165+
$panel->setEditURI($board_uri.'column/'.$column->getID().'/');
166166
}
167167
$panel->setHeaderAction(id(new PHUIIconView())
168168
->setIconFont('fa-plus')
@@ -290,11 +290,6 @@ public function processRequest() {
290290
->setHref('#')
291291
->addSigil('boards-filter-menu')
292292

293-
/*
294-
TODO: @chad, this looks really gnarly right now, at least in Safari.
295-
->setDropdown(true)
296-
*/
297-
298293
->setMetadata(
299294
array(
300295
'items' => hsprintf('%s', $filter_menu),

webroot/rsrc/css/phui/phui-button.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,11 @@ button.simple:hover {
124124
box-shadow: none;
125125
}
126126

127+
a.button.simple.phuix-dropdown-open {
128+
background-color: #fff;
129+
box-shadow: none;
130+
}
131+
127132
a.button.grey:hover,
128133
button.grey:hover {
129134
text-decoration: none;

0 commit comments

Comments
 (0)