Skip to content

Commit 6b17a5a

Browse files
joshuaspenceepriestley
authored andcommitted
Fix str being defined as a global variable
Summary: This variable should be local, not global. This silences a few JSHint warnings. Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11068
1 parent fdd1357 commit 6b17a5a

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

resources/celerity/map.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@
383383
'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
384384
'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f24f3253',
385385
'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
386-
'rsrc/js/application/maniphest/behavior-line-chart.js' => '22e16ae7',
386+
'rsrc/js/application/maniphest/behavior-line-chart.js' => 'b07b009f',
387387
'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
388388
'rsrc/js/application/maniphest/behavior-subpriorityeditor.js' => '84845b5b',
389389
'rsrc/js/application/maniphest/behavior-transaction-controls.js' => '44168bad',
@@ -587,7 +587,7 @@
587587
'javelin-behavior-konami' => '5bc2cb21',
588588
'javelin-behavior-launch-icon-composer' => '48086888',
589589
'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
590-
'javelin-behavior-line-chart' => '22e16ae7',
590+
'javelin-behavior-line-chart' => 'b07b009f',
591591
'javelin-behavior-load-blame' => '42126667',
592592
'javelin-behavior-maniphest-batch-editor' => 'f24f3253',
593593
'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
@@ -950,11 +950,6 @@
950950
'javelin-workflow',
951951
'javelin-util',
952952
),
953-
'22e16ae7' => array(
954-
'javelin-behavior',
955-
'javelin-dom',
956-
'javelin-vector',
957-
),
958953
'2926fff2' => array(
959954
'javelin-behavior',
960955
'javelin-dom',
@@ -1512,6 +1507,11 @@
15121507
'javelin-dom',
15131508
'javelin-vector',
15141509
),
1510+
'b07b009f' => array(
1511+
'javelin-behavior',
1512+
'javelin-dom',
1513+
'javelin-vector',
1514+
),
15151515
'b1f0ccee' => array(
15161516
'javelin-install',
15171517
'javelin-dom',

webroot/rsrc/js/application/maniphest/behavior-line-chart.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ JX.behavior('line-chart', function(config) {
4949
text[k].attr({text: ''});
5050
} else {
5151
var cur = text[k].attr('text');
52-
str = format(cur, config.xformat);
52+
var str = format(cur, config.xformat);
5353
text[k].attr({text: str});
5454
}
5555
}

0 commit comments

Comments
 (0)