(Redesign) Clean up older "Tile" code

Summary:
This does some backend cleanup of the tile stuff, and some general cleanup of other application things:

  - Users who haven't customized preferences get a small, specific set of pinned applications: Differential, Maniphest, Diffusion, Audit, Phriction, Projects (and, for administrators, Auth, Config and People).
  - Old tile size methods are replaced with `isPinnnedByDefault()`.
  - Shortened some short descriptions.
  - `shouldAppearInLaunchView()` replaced by less ambiguous `isLaunchable()`.
  - Added a marker for third-party / extension applications.

Test Plan: Faked away my preferences and viewed the home page, saw a smaller set of default pins.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D9358

Author: epriestley

src/applications/audit/application/PhabricatorApplicationAudit.php

@@ -14,6 +14,10 @@ public function getShortDescription() {
     return pht('Browse and Audit Commits');
   }
 
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return true;
+  }
+
   public function getHelpURI() {
     return PhabricatorEnv::getDoclink('Audit User Guide');
   }
@@ -34,10 +38,6 @@ public function getRoutes() {
     );
   }
 
-  public function getApplicationGroup() {
-    return self::GROUP_CORE;
-  }
-
   public function getApplicationOrder() {
     return 0.130;
   }

src/applications/auth/application/PhabricatorApplicationAuth.php

@@ -14,8 +14,12 @@ public function getIconName() {
     return 'authentication';
   }
 
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return $viewer->getIsAdmin();
+  }
+
   public function getShortDescription() {
-    return pht('Configure Login and Registration');
+    return pht('Login/Registration');
   }
 
   public function getHelpURI() {

src/applications/base/PhabricatorApplication.php

@@ -16,11 +16,6 @@ abstract class PhabricatorApplication
   const GROUP_ADMIN           = 'admin';
   const GROUP_DEVELOPER       = 'developer';
 
-  const TILE_INVISIBLE        = 'invisible';
-  const TILE_HIDE             = 'hide';
-  const TILE_SHOW             = 'show';
-  const TILE_FULL             = 'full';
-
   public static function getApplicationGroups() {
     return array(
       self::GROUP_CORE          => pht('Core Applications'),
@@ -30,20 +25,10 @@ public static function getApplicationGroups() {
     );
   }
 
-  public static function getTileDisplayName($constant) {
-    $names = array(
-      self::TILE_INVISIBLE => pht('Invisible'),
-      self::TILE_HIDE => pht('Hidden'),
-      self::TILE_SHOW => pht('Show Small Tile'),
-      self::TILE_FULL => pht('Show Large Tile'),
-    );
-    return idx($names, $constant);
-  }
-
-
 
 /* -(  Application Information  )-------------------------------------------- */
 
+
   public function getName() {
     return substr(get_class($this), strlen('PhabricatorApplication'));
   }
@@ -68,21 +53,63 @@ public function isInstalled() {
     return empty($uninstalled[get_class($this)]);
   }
 
+
   public function isBeta() {
     return false;
   }
 
+
   /**
-   * Return true if this application should not appear in application lists in
-   * the UI. Primarily intended for unit test applications or other
+   * Return `true` if this application should never appear in application lists
+   * in the UI. Primarily intended for unit test applications or other
    * pseudo-applications.
    *
+   * Few applications should be unlisted. For most applications, use
+   * @{method:isLaunchable} to hide them from main launch views instead.
+   *
    * @return bool True to remove application from UI lists.
    */
   public function isUnlisted() {
     return false;
   }
 
+
+  /**
+   * Return `true` if this application is a normal application with a base
+   * URI and a web interface.
+   *
+   * Launchable applications can be pinned to the home page, and show up in the
+   * "Launcher" view of the Applications application. Making an application
+   * unlauncahble prevents pinning and hides it from this view.
+   *
+   * Usually, an application should be marked unlaunchable if:
+   *
+   *   - it is available on every page anyway (like search); or
+   *   - it does not have a web interface (like subscriptions); or
+   *   - it is still pre-release and being intentionally buried.
+   *
+   * To hide applications more completely, use @{method:isUnlisted}.
+   *
+   * @return bool True if the application is launchable.
+   */
+  public function isLaunchable() {
+    return true;
+  }
+
+
+  /**
+   * Return `true` if this application should be pinned by default.
+   *
+   * Users who have not yet set preferences see a default list of applications.
+   *
+   * @param PhabricatorUser User viewing the pinned application list.
+   * @return bool True if this application should be pinned by default.
+   */
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return false;
+  }
+
+
   /**
    * Returns true if an application is first-party (developed by Phacility)
    * and false otherwise.
@@ -113,7 +140,7 @@ public function getPHID() {
   }
 
   public function getTypeaheadURI() {
-    return $this->getBaseURI();
+    return $this->isLaunchable() ? $this->getBaseURI() : null;
   }
 
   public function getBaseURI() {
@@ -132,10 +159,6 @@ public function getIconName() {
     return 'application';
   }
 
-  public function shouldAppearInLaunchView() {
-    return true;
-  }
-
   public function getApplicationOrder() {
     return PHP_INT_MAX;
   }
@@ -160,25 +183,6 @@ public function getEventListeners() {
     return array();
   }
 
-  public function getDefaultTileDisplay(PhabricatorUser $user) {
-    switch ($this->getApplicationGroup()) {
-      case self::GROUP_CORE:
-        return self::TILE_FULL;
-      case self::GROUP_UTILITIES:
-      case self::GROUP_DEVELOPER:
-        return self::TILE_HIDE;
-      case self::GROUP_ADMIN:
-        if ($user->getIsAdmin()) {
-          return self::TILE_SHOW;
-        } else {
-          return self::TILE_INVISIBLE;
-        }
-        break;
-      default:
-        return self::TILE_SHOW;
-    }
-  }
-
   public function getRemarkupRules() {
     return array();
   }

src/applications/base/controller/__tests__/PhabricatorApplicationTest.php

@@ -8,6 +8,10 @@ public function isUnlisted() {
     return true;
   }
 
+  public function isLaunchable() {
+    return false;
+  }
+
   public function reset() {
     $this->policies = array();
   }
@@ -21,10 +25,6 @@ public function getPolicy($capability) {
     return idx($this->policies, $capability, parent::getPolicy($capability));
   }
 
-  public function shouldAppearInLaunchView() {
-    return false;
-  }
-
   public function canUninstall() {
     return false;
   }

src/applications/conduit/application/PhabricatorApplicationConduit.php

@@ -19,7 +19,7 @@ public function getHelpURI() {
   }
 
   public function getShortDescription() {
-    return pht('Phabricator Developer API Console');
+    return pht('Developer API');
   }
 
   public function getTitleGlyph() {

src/applications/config/application/PhabricatorApplicationConfig.php

@@ -10,6 +10,10 @@ public function getIconName() {
     return 'setup';
   }
 
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return $viewer->getIsAdmin();
+  }
+
   public function getTitleGlyph() {
     return "\xE2\x98\xBA";
   }

src/applications/dashboard/application/PhabricatorApplicationDashboard.php

@@ -48,7 +48,13 @@ public function getRemarkupRules() {
     );
   }
 
-  public function shouldAppearInLaunchView() {
+  public function isBeta() {
+    return true;
+  }
+
+  public function isLaunchable() {
+    // TODO: This is just concealing the application from launch views for
+    // now since it's not really beta yet.
     return false;
   }
 

src/applications/differential/application/PhabricatorApplicationDifferential.php

@@ -14,6 +14,10 @@ public function getIconName() {
     return 'differential';
   }
 
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return true;
+  }
+
   public function getHelpURI() {
     return PhabricatorEnv::getDoclink('Differential User Guide');
   }
@@ -74,10 +78,6 @@ public function getRoutes() {
     );
   }
 
-  public function getApplicationGroup() {
-    return self::GROUP_CORE;
-  }
-
   public function getApplicationOrder() {
     return 0.100;
   }

src/applications/diffusion/application/PhabricatorApplicationDiffusion.php

@@ -14,6 +14,10 @@ public function getIconName() {
     return 'diffusion';
   }
 
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return true;
+  }
+
   public function getHelpURI() {
     return PhabricatorEnv::getDoclink('Diffusion User Guide');
   }
@@ -116,10 +120,6 @@ public function getRoutes() {
     );
   }
 
-  public function getApplicationGroup() {
-    return self::GROUP_CORE;
-  }
-
   public function getApplicationOrder() {
     return 0.120;
   }

src/applications/doorkeeper/application/PhabricatorApplicationDoorkeeper.php

@@ -6,7 +6,7 @@ public function canUninstall() {
     return false;
   }
 
-  public function shouldAppearInLaunchView() {
+  public function isLaunchable() {
     return false;
   }
 

src/applications/flag/application/PhabricatorApplicationFlags.php

@@ -3,7 +3,7 @@
 final class PhabricatorApplicationFlags extends PhabricatorApplication {
 
   public function getShortDescription() {
-    return pht('Personal Bookmarks and Reminders');
+    return pht('Personal Bookmarks');
   }
 
   public function getBaseURI() {

src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php

@@ -7,7 +7,7 @@ public function getBaseURI() {
   }
 
   public function getShortDescription() {
-    return pht('Builds and Continuous Integration');
+    return pht('Build/CI');
   }
 
   public function getIconName() {

src/applications/home/application/PhabricatorApplicationHome.php

@@ -23,7 +23,7 @@ public function getRoutes() {
     );
   }
 
-  public function shouldAppearInLaunchView() {
+  public function isLaunchable() {
     return false;
   }
 

src/applications/home/controller/PhabricatorHomeController.php

@@ -28,14 +28,6 @@ public function buildNav() {
       ->withLaunchable(true)
       ->execute();
 
-    foreach ($applications as $key => $application) {
-      $invisible = PhabricatorApplication::TILE_INVISIBLE;
-      if ($application->getDefaultTileDisplay($user) == $invisible) {
-        // Remove invisible applications (e.g., admin apps for non-admins).
-        unset($applications[$key]);
-      }
-    }
-
     $pinned = $user->loadPreferences()->getPinnedApplications(
       $applications,
       $user);

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

@@ -14,8 +14,8 @@ public function getIconName() {
     return 'maniphest';
   }
 
-  public function getApplicationGroup() {
-    return self::GROUP_CORE;
+  public function isPinnedByDefault(PhabricatorUser $viewer) {
+    return true;
   }
 
   public function getApplicationOrder() {

src/applications/meta/application/PhabricatorApplicationApplications.php

@@ -6,6 +6,12 @@ public function canUninstall() {
     return false;
   }
 
+  public function isLaunchable() {
+    // This application is launchable in the traditional sense, but showing it
+    // on the application launch list is confusing.
+    return false;
+  }
+
   public function getBaseURI() {
     return '/applications/';
   }

src/applications/meta/query/PhabricatorAppSearchEngine.php

@@ -226,13 +226,17 @@ protected function renderResultList(
         }
 
         if (!$application->isInstalled()) {
-          $item->addIcon('delete', pht('Uninstalled'));
+          $item->addIcon('fa-times', pht('Uninstalled'));
         }
 
         if ($application->isBeta()) {
           $item->addIcon('fa-star-half-o grey', pht('Beta'));
         }
 
+        if (!$application->isFirstParty()) {
+          $item->addIcon('fa-puzzle-piece', pht('Extension'));
+        }
+
         $list->addItem($item);
       }
 

src/applications/meta/query/PhabricatorApplicationQuery.php

@@ -125,7 +125,7 @@ public function loadPage() {
 
     if ($this->launchable !== null) {
       foreach ($apps as $key => $app) {
-        if ($app->shouldAppearInLaunchView() != $this->launchable) {
+        if ($app->isLaunchable() != $this->launchable) {
           unset($apps[$key]);
         }
       }

src/applications/metamta/application/PhabricatorApplicationMetaMTA.php

@@ -22,7 +22,7 @@ public function canUninstall() {
     return false;
   }
 
-  public function shouldAppearInLaunchView() {
+  public function isLaunchable() {
     return false;
   }