Skip to content

Commit 87f11a0

Browse files
committed
Minor improvements to handling Aphlict status code
Summary: Self explanatory. Test Plan: `curl`ed a few URLs. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11147
1 parent 9f31e02 commit 87f11a0

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

support/aphlict/server/aphlict_server.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,23 +206,20 @@ http.createServer(function(request, response) {
206206
'<%s> Internal Server Error! %s',
207207
request.socket.remoteAddress,
208208
err);
209-
response.statusCode = 500;
210-
response.write('500 Internal Server Error\n');
209+
response.writeHead(500, 'Internal Server Error');
211210
}
212211
} catch (err) {
213212
debug.log(
214213
'<%s> Bad Request! %s',
215214
request.socket.remoteAddress,
216215
err);
217-
response.statusCode = 400;
218-
response.write('400 Bad Request\n');
216+
response.writeHead(400, 'Bad Request');
219217
} finally {
220218
response.end();
221219
}
222220
});
223221
} else {
224-
response.statusCode = 405;
225-
response.write('405 Method Not Allowed\n');
222+
response.writeHead(405, 'Method Not Allowed');
226223
response.end();
227224
}
228225
} else if (request.url == '/status/') {
@@ -240,8 +237,7 @@ http.createServer(function(request, response) {
240237
response.write(JSON.stringify(status));
241238
response.end();
242239
} else {
243-
response.statusCode = 404;
244-
response.write('404 Not Found\n');
240+
response.writeHead(404, 'Not Found');
245241
response.end();
246242
}
247243
}).listen(config.admin, config.host);

0 commit comments

Comments
 (0)