Remove DifferentialComment

Summary: Ref T2222. Remove this; no more callsites.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8477

Author: epriestley

resources/celerity/map.php

@@ -11,7 +11,7 @@
     'core.pkg.js' => 'b7bdab05',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => 'd1b3a605',
-    'differential.pkg.js' => 'e0d3b0da',
+    'differential.pkg.js' => '11a5b750',
     'diffusion.pkg.css' => '3783278d',
     'diffusion.pkg.js' => '5b4010f4',
     'javelin.pkg.js' => '5b0f988e',
@@ -357,7 +357,6 @@
     'rsrc/js/application/conpherence/behavior-widget-pane.js' => 'd8ef8659',
     'rsrc/js/application/countdown/timer.js' => '889c96f3',
     'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => 'f2441746',
-    'rsrc/js/application/differential/behavior-accept-with-errors.js' => 'e12c760a',
     'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => '533a187b',
     'rsrc/js/application/differential/behavior-comment-jump.js' => '71755c79',
     'rsrc/js/application/differential/behavior-comment-preview.js' => '127f2018',
@@ -546,7 +545,6 @@
     'javelin-behavior-countdown-timer' => '889c96f3',
     'javelin-behavior-dark-console' => 'e9fdb5e5',
     'javelin-behavior-device' => '03d6ed07',
-    'javelin-behavior-differential-accept-with-errors' => 'e12c760a',
     'javelin-behavior-differential-add-reviewers-and-ccs' => '533a187b',
     'javelin-behavior-differential-comment-jump' => '71755c79',
     'javelin-behavior-differential-diff-radios' => 'e1ff79b1',
@@ -1817,11 +1815,6 @@
       1 => 'javelin-util',
       2 => 'javelin-request',
     ),
-    'e12c760a' =>
-    array(
-      0 => 'javelin-behavior',
-      1 => 'javelin-dom',
-    ),
     'e1ff79b1' =>
     array(
       0 => 'javelin-behavior',
@@ -2140,18 +2133,17 @@
       4 => 'javelin-behavior-differential-populate',
       5 => 'javelin-behavior-differential-show-more',
       6 => 'javelin-behavior-differential-diff-radios',
-      7 => 'javelin-behavior-differential-accept-with-errors',
-      8 => 'javelin-behavior-differential-comment-jump',
-      9 => 'javelin-behavior-differential-add-reviewers-and-ccs',
-      10 => 'javelin-behavior-differential-keyboard-navigation',
-      11 => 'javelin-behavior-aphront-drag-and-drop-textarea',
-      12 => 'javelin-behavior-phabricator-object-selector',
-      13 => 'javelin-behavior-repository-crossreference',
-      14 => 'javelin-behavior-load-blame',
-      15 => 'differential-inline-comment-editor',
-      16 => 'javelin-behavior-differential-dropdown-menus',
-      17 => 'javelin-behavior-differential-toggle-files',
-      18 => 'javelin-behavior-differential-user-select',
+      7 => 'javelin-behavior-differential-comment-jump',
+      8 => 'javelin-behavior-differential-add-reviewers-and-ccs',
+      9 => 'javelin-behavior-differential-keyboard-navigation',
+      10 => 'javelin-behavior-aphront-drag-and-drop-textarea',
+      11 => 'javelin-behavior-phabricator-object-selector',
+      12 => 'javelin-behavior-repository-crossreference',
+      13 => 'javelin-behavior-load-blame',
+      14 => 'differential-inline-comment-editor',
+      15 => 'javelin-behavior-differential-dropdown-menus',
+      16 => 'javelin-behavior-differential-toggle-files',
+      17 => 'javelin-behavior-differential-user-select',
     ),
     'diffusion.pkg.css' =>
     array(

resources/sql/autopatches/20140212.dx.1.armageddon.php

@@ -42,10 +42,10 @@
     $metadata = array();
   }
 
-  $key_cc = DifferentialComment::METADATA_ADDED_CCS;
-  $key_add_rev = DifferentialComment::METADATA_ADDED_REVIEWERS;
-  $key_rem_rev = DifferentialComment::METADATA_REMOVED_REVIEWERS;
-  $key_diff_id = DifferentialComment::METADATA_DIFF_ID;
+  $key_cc = 'added-ccs';
+  $key_add_rev = 'added-reviewers';
+  $key_rem_rev = 'removed-reviewers';
+  $key_diff_id = 'diff-id';
 
   $xactions = array();
 

src/__phutil_library_map__.php

@@ -343,7 +343,6 @@
     'DifferentialChangesetTwoUpRenderer' => 'applications/differential/render/DifferentialChangesetTwoUpRenderer.php',
     'DifferentialChangesetTwoUpTestRenderer' => 'applications/differential/render/DifferentialChangesetTwoUpTestRenderer.php',
     'DifferentialChangesetViewController' => 'applications/differential/controller/DifferentialChangesetViewController.php',
-    'DifferentialComment' => 'applications/differential/storage/DifferentialComment.php',
     'DifferentialCommentPreviewController' => 'applications/differential/controller/DifferentialCommentPreviewController.php',
     'DifferentialCommentSaveController' => 'applications/differential/controller/DifferentialCommentSaveController.php',
     'DifferentialCommitMessageParser' => 'applications/differential/parser/DifferentialCommitMessageParser.php',
@@ -2864,7 +2863,6 @@
     'DifferentialChangesetTwoUpRenderer' => 'DifferentialChangesetHTMLRenderer',
     'DifferentialChangesetTwoUpTestRenderer' => 'DifferentialChangesetTestRenderer',
     'DifferentialChangesetViewController' => 'DifferentialController',
-    'DifferentialComment' => 'PhabricatorMarkupInterface',
     'DifferentialCommentPreviewController' => 'DifferentialController',
     'DifferentialCommentSaveController' => 'DifferentialController',
     'DifferentialCommitMessageParserTestCase' => 'PhabricatorTestCase',