phacility · Mar 30, 2014 · Mar 30, 2014 · Mar 30, 2014
Showing with 16 additions and 0 deletions.

+2 −0 src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php

+14 −0 src/applications/differential/customfield/DifferentialJIRAIssuesField.php
diff --git a/src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php b/src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php
@@ -64,6 +64,7 @@ protected function execute(ConduitAPIRequest $request) {
       $fields = $request->getValue('fields', array());
       foreach ($fields as $field => $value) {
         $custom_field = idx($field_map, $field);
+
         if (!$custom_field) {
           // Just ignore this, these workflows don't make strong distictions
           // about field editability on the client side.
@@ -79,6 +80,7 @@ protected function execute(ConduitAPIRequest $request) {
     $phids = array();
     foreach ($field_list->getFields() as $key => $field) {
       $field_phids = $field->getRequiredHandlePHIDsForCommitMessage();
+
       if (!is_array($field_phids)) {
         throw new Exception(
           pht(

diff --git a/src/applications/differential/customfield/DifferentialJIRAIssuesField.php b/src/applications/differential/customfield/DifferentialJIRAIssuesField.php
@@ -276,4 +276,18 @@ public function shouldAppearInConduitDictionary() {
     return true;
   }
 
+public function getRequiredHandlePHIDsForCommitMessage() {
+	$result = $this->getValue();
+
+	if(null === $result) {
+		return array();
+	}
+
+	return $result;
+}
+
+public function readValueFromCommitMessage($value) {
+	$this->setValue($value);
+}
+
 }