crate.settings: Add "Remove" button to Trusted Publishing configs

Author: Turbo87

app/controllers/crate/settings.js

@@ -7,6 +7,7 @@ import { task } from 'ember-concurrency';
 
 export default class CrateSettingsController extends Controller {
   @service notifications;
+  @service store;
 
   crate = null;
   username = '';
@@ -64,6 +65,22 @@ export default class CrateSettingsController extends Controller {
       this.notifications.error(message);
     }
   });
+
+  removeConfigTask = task(async config => {
+    try {
+      await config.destroyRecord();
+      this.notifications.success('Trusted Publishing configuration removed successfully');
+    } catch (error) {
+      let message = 'Failed to remove Trusted Publishing configuration';
+
+      let detail = error.errors?.[0]?.detail;
+      if (detail && !detail.startsWith('{')) {
+        message += `: ${detail}`;
+      }
+
+      this.notifications.error(message);
+    }
+  });
 }
 
 function removeOwner(owners, target) {

app/styles/crate/settings.module.css

@@ -61,6 +61,10 @@
         font-size: 0.85em;
         line-height: 1.5;
     }
+
+    .actions {
+        text-align: right;
+    }
 }
 
 .email-column {

app/templates/crate/settings.hbs

@@ -63,6 +63,7 @@
     <tr>
       <th>Publisher</th>
       <th>Details</th>
+      <th></th>
     </tr>
     </thead>
     <tbody>
@@ -76,10 +77,13 @@
             <strong>Environment:</strong> {{config.environment}}
           {{/if}}
         </td>
+        <td local-class="actions">
+          <button type="button" class="button button--small" data-test-remove-config-button {{on "click" (perform this.removeConfigTask config)}}>Remove</button>
+        </td>
       </tr>
     {{else}}
       <tr data-test-no-config>
-        <td colspan="2">No trusted publishers configured for this crate.</td>
+        <td colspan="3">No trusted publishers configured for this crate.</td>
       </tr>
     {{/each}}
     </tbody>

e2e/routes/crate/settings.spec.ts

@@ -1,4 +1,6 @@
 import { expect, test } from '@/e2e/helper';
+import { click } from '@ember/test-helpers';
+import { http, HttpResponse } from 'msw';
 
 test.describe('Route | crate.settings', { tag: '@routes' }, () => {
   async function prepare(msw) {
@@ -90,12 +92,55 @@ test.describe('Route | crate.settings', { tag: '@routes' }, () => {
       await expect(details).toContainText('Repository: rust-lang/crates.io');
       await expect(details).toContainText('Workflow: ci.yml');
       await expect(details).not.toContainText('Environment');
+      await expect(page.locator('[data-test-github-config="1"] [data-test-remove-config-button]')).toBeVisible();
       await expect(page.locator('[data-test-github-config="2"] td:nth-child(1)')).toHaveText('GitHub');
       details = page.locator('[data-test-github-config="2"] td:nth-child(2)');
       await expect(details).toContainText('Repository: johndoe/crates.io');
       await expect(details).toContainText('Workflow: release.yml');
       await expect(details).toContainText('Environment: release');
+      await expect(page.locator('[data-test-github-config="2"] [data-test-remove-config-button]')).toBeVisible();
       await expect(page.locator('[data-test-no-config]')).not.toBeVisible();
+
+      // Click the remove button
+      await page.click('[data-test-github-config="2"] [data-test-remove-config-button]');
+
+      // Check that the config is no longer displayed
+      await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
+      details = page.locator('[data-test-github-config="1"] td:nth-child(2)');
+      await expect(details).toContainText('Repository: rust-lang/crates.io');
+      await expect(page.locator('[data-test-notification-message]')).toHaveText(
+        'Trusted Publishing configuration removed successfully',
+      );
+    });
+
+    test('deletion failure', async ({ msw, page, percy }) => {
+      let { crate } = await prepare(msw);
+
+      // Create a GitHub config for the crate
+      let config = msw.db.trustpubGithubConfig.create({
+        crate,
+        repository_owner: 'rust-lang',
+        repository_name: 'crates.io',
+        workflow_filename: 'ci.yml',
+        environment: 'release',
+      });
+
+      // Mock the server to return an error when trying to delete the config
+      await msw.worker.use(
+        http.delete(`/api/v1/trusted_publishing/github_configs/${config.id}`, () => {
+          return HttpResponse.json({ errors: [{ detail: 'Server error' }] }, { status: 500 });
+        }),
+      );
+
+      await page.goto(`/crates/${crate.name}/settings`);
+      await expect(page).toHaveURL(`/crates/${crate.name}/settings`);
+      await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
+
+      await page.click('[data-test-remove-config-button]');
+      await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
+      await expect(page.locator('[data-test-notification-message]')).toHaveText(
+        'Failed to remove Trusted Publishing configuration: Server error',
+      );
     });
   });
 });

tests/routes/crate/settings-test.js

@@ -1,7 +1,8 @@
-import { currentURL } from '@ember/test-helpers';
+import { click, currentURL } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 
 import percySnapshot from '@percy/ember';
+import { http, HttpResponse } from 'msw';
 
 import { setupApplicationTest } from 'crates-io/tests/helpers';
 
@@ -96,11 +97,52 @@ module('Route | crate.settings', hooks => {
       assert.dom('[data-test-github-config="1"] td:nth-child(2)').includesText('Repository: rust-lang/crates.io');
       assert.dom('[data-test-github-config="1"] td:nth-child(2)').includesText('Workflow: ci.yml');
       assert.dom('[data-test-github-config="1"] td:nth-child(2)').doesNotIncludeText('Environment');
+      assert.dom('[data-test-github-config="1"] [data-test-remove-config-button]').exists();
       assert.dom('[data-test-github-config="2"] td:nth-child(1)').hasText('GitHub');
       assert.dom('[data-test-github-config="2"] td:nth-child(2)').includesText('Repository: johndoe/crates.io');
       assert.dom('[data-test-github-config="2"] td:nth-child(2)').includesText('Workflow: release.yml');
       assert.dom('[data-test-github-config="2"] td:nth-child(2)').includesText('Environment: release');
+      assert.dom('[data-test-github-config="2"] [data-test-remove-config-button]').exists();
       assert.dom('[data-test-no-config]').doesNotExist();
+
+      // Click the remove button
+      await click('[data-test-github-config="2"] [data-test-remove-config-button]');
+
+      // Check that the config is no longer displayed
+      assert.dom('[data-test-github-config]').exists({ count: 1 });
+      assert.dom('[data-test-github-config="1"] td:nth-child(2)').includesText('Repository: rust-lang/crates.io');
+      assert.dom('[data-test-notification-message]').hasText('Trusted Publishing configuration removed successfully');
+    });
+
+    test('deletion failure', async function (assert) {
+      let { crate, user } = prepare(this);
+      this.authenticateAs(user);
+
+      // Create a GitHub config for the crate
+      let config = this.db.trustpubGithubConfig.create({
+        crate,
+        repository_owner: 'rust-lang',
+        repository_name: 'crates.io',
+        workflow_filename: 'ci.yml',
+        environment: 'release',
+      });
+
+      // Mock the server to return an error when trying to delete the config
+      this.worker.use(
+        http.delete(`/api/v1/trusted_publishing/github_configs/${config.id}`, () => {
+          return HttpResponse.json({ errors: [{ detail: 'Server error' }] }, { status: 500 });
+        }),
+      );
+
+      await visit(`/crates/${crate.name}/settings`);
+      assert.strictEqual(currentURL(), `/crates/${crate.name}/settings`);
+      assert.dom('[data-test-github-config]').exists({ count: 1 });
+
+      await click('[data-test-remove-config-button]');
+      assert.dom('[data-test-github-config]').exists({ count: 1 });
+      assert
+        .dom('[data-test-notification-message]')
+        .hasText('Failed to remove Trusted Publishing configuration: Server error');
     });
   });
 });