Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rustdoc strippers #138168

Open
GuillaumeGomez opened this issue Mar 7, 2025 · 1 comment
Open

Improve rustdoc strippers #138168

GuillaumeGomez opened this issue Mar 7, 2025 · 1 comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Mar 7, 2025 •
edited
Loading

Currently, rustdoc goes through multiple passes to inline reexports, remove hidden/private items.

First, we go through the whole crate AST, to convert types into rustdoc types (although the rustdoc types are now more and more just wrapper around rustc types), then we run these passes. However: couldn't we do the stripping as part of this conversion?

It could also potentially help with performance in cases like #137534.
@GuillaumeGomez GuillaumeGomez added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 7, 2025
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 7, 2025
Merged
@xizheyin
Copy link
Contributor

xizheyin commented Mar 7, 2025

Previous discussions are in #137342 and #137979.

@Kobzol Kobzol mentioned this issue Mar 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @xizheyin