Turn order dependent trait objects future incompat warning into a hard error #136968

oli-obk · 2025-02-13T10:04:42Z

will FCP when we have a crater result

oli-obk · 2025-02-13T10:04:50Z

Turn order dependent trait objects future incompat warning into a hard error fixes rust-lang#56484 r? `@ghost` will FCP when we have a crater result

bors · 2025-02-13T10:06:03Z

⌛ Trying commit 0ae0780 with merge 9d63f82...

bors · 2025-02-13T12:00:12Z

☀️ Try build successful - checks-actions
Build commit: 9d63f82 (9d63f825c0d409b0e1743a2c84b33f86965e5929)

oli-obk · 2025-02-13T13:07:46Z

@craterbot check

craterbot · 2025-02-13T13:08:04Z

👌 Experiment pr-136968 created and queued.
🤖 Automatically detected try build 9d63f82
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-02-13T19:54:05Z

🚧 Experiment pr-136968 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-02-14T16:54:36Z

🎉 Experiment pr-136968 is completed!
📊 506 regressed and 4 fixed (582562 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

oli-obk · 2025-02-14T17:11:11Z

🤔 hmm all the failures are because of crates with lockfiles for traitobject 0.1.0, even though traitobject 0.1.1 resolves the issues.

…d error

oli-obk · 2025-02-25T09:18:41Z

cc @rust-lang/lang

We've had a future incompatibility warning for years for code like

trait Trait {}
impl Trait for dyn Send + Sync {}
impl Trait for dyn Sync + Send {}

We already hard error if the trait has methods, but due to some widespread breakage, we decided not to make it a hard error. All (yes all) of the breakage is due to crates depending (mostly transitively) on the traitobject. @reem recently gave me crates.io ownership and I published a patch update, so everyone can just cargo update -p traitobject without causing any other problems.

There are only 10 crates on crates.io that break from this PR, and all of them also were due to lockfiles. All but

https://crates.io/crates/gnostr-cat/0.0.40 (cli tool, git version already doesn't contain traitobject anymore at all)
https://crates.io/crates/simple-http-server/0.6.10 (cli tool, PR for bumping traitobject dep open)

haven't seen updates in 4 years and are usually depending on an old version of hyper that still had traitobject in its dependency graph at all.

We should turn this FCW into a hard error and thus be able to rip out all the code that was necessary to maintain it

@rfcbot merge

rfcbot · 2025-02-25T09:18:44Z

Team member @oli-obk has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

oli-obk · 2025-02-25T09:18:56Z

r? types

nikomatsakis · 2025-02-26T22:02:09Z

@rfcbot reviewed

rfcbot · 2025-02-26T22:02:15Z

🔔 This is now entering its final comment period, as per the review above. 🔔

compiler-errors · 2025-02-28T03:44:55Z

r=me when FCP is done

@rustbot author

rust-lang/rust#136968 will make this a hard error.

rfcbot · 2025-03-08T22:11:50Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

compiler-errors · 2025-03-08T22:12:51Z

@bors r+ rollup

bors · 2025-03-08T22:12:53Z

📌 Commit 8f6b184 has been approved by compiler-errors

It is now in the queue for this repository.

Turn order dependent trait objects future incompat warning into a hard error fixes rust-lang#56484 r? `@ghost` will FCP when we have a crater result

Rollup of 16 pull requests Successful merges: - rust-lang#122790 (Apply dllimport in ThinLTO) - rust-lang#136127 (Allow `*const W<dyn A> -> *const dyn A` ptr cast) - rust-lang#136968 (Turn order dependent trait objects future incompat warning into a hard error) - rust-lang#137147 (Add exclude to config.toml) - rust-lang#137319 (Stabilize `const_vec_string_slice`) - rust-lang#137885 (tidy: add triagebot checks) - rust-lang#138040 (compiler: Use `size_of` from the prelude instead of imported) - rust-lang#138052 (strip `-Wlinker-messages` wrappers from `rust-lld` rmake test) - rust-lang#138084 (Use workspace lints for crates in `compiler/`) - rust-lang#138158 (Move more layouting logic to `rustc_abi`) - rust-lang#138160 (depend more on attr_data_structures and move find_attr! there) - rust-lang#138192 (crashes: couple more tests) - rust-lang#138216 (bootstrap: Fix stack printing when a step cycle is detected) - rust-lang#138232 (Reduce verbosity of GCC build log) - rust-lang#138233 (Windows: Don't link std (and run-make) against advapi32, except on win7) - rust-lang#138242 (Revert "Don't test new error messages with the stage 0 compiler") r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#136127 (Allow `*const W<dyn A> -> *const dyn A` ptr cast) - rust-lang#136968 (Turn order dependent trait objects future incompat warning into a hard error) - rust-lang#137319 (Stabilize `const_vec_string_slice`) - rust-lang#137885 (tidy: add triagebot checks) - rust-lang#138040 (compiler: Use `size_of` from the prelude instead of imported) - rust-lang#138084 (Use workspace lints for crates in `compiler/`) - rust-lang#138158 (Move more layouting logic to `rustc_abi`) - rust-lang#138160 (depend more on attr_data_structures and move find_attr! there) - rust-lang#138192 (crashes: couple more tests) - rust-lang#138216 (bootstrap: Fix stack printing when a step cycle is detected) - rust-lang#138232 (Reduce verbosity of GCC build log) - rust-lang#138242 (Revert "Don't test new error messages with the stage 0 compiler") r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136968 - oli-obk:bye-bye, r=compiler-errors Turn order dependent trait objects future incompat warning into a hard error fixes rust-lang#56484 r? ``@ghost`` will FCP when we have a crater result

Kobzol · 2025-03-09T20:28:33Z

@rust-timer build 702badc

rust-timer · 2025-03-09T22:58:33Z

Finished benchmarking commit (702badc): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.2%, 4.2%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.417s -> 765.101s (-0.04%)
Artifact size: 362.05 MiB -> 362.02 MiB (-0.01%)

rustbot added S-waiting-on-review T-compiler labels Feb 13, 2025

craterbot added S-waiting-on-crater and removed S-waiting-on-review labels Feb 13, 2025

craterbot added S-waiting-on-review and removed S-waiting-on-crater labels Feb 14, 2025

Turn order dependent trait objects future incompat warning into a har…

8f6b184

…d error

oli-obk force-pushed the bye-bye branch from 0ae0780 to 8f6b184 Compare February 20, 2025 13:41

oli-obk marked this pull request as ready for review February 25, 2025 09:00

oli-obk added T-types and removed T-compiler labels Feb 25, 2025

oli-obk mentioned this pull request Feb 25, 2025

Bump traitobject dependency TheWaWaR/simple-http-server#129

Merged

rfcbot added proposed-final-comment-period disposition-merge labels Feb 25, 2025

rustbot assigned compiler-errors Feb 25, 2025

traviscross added the I-lang-nominated label Feb 25, 2025

tmandry added T-lang and removed T-lang labels Feb 26, 2025

rustbot removed the I-lang-nominated label Feb 26, 2025

traviscross added the T-lang label Feb 26, 2025

rfcbot added final-comment-period and removed proposed-final-comment-period labels Feb 26, 2025

rustbot added S-waiting-on-author and removed S-waiting-on-review labels Feb 28, 2025

Mark-Simulacrum added a commit to rust-lang/rfcbot-rs that referenced this pull request Mar 1, 2025

Avoid breakage in upcoming Rust release

766cc9e

rust-lang/rust#136968 will make this a hard error.

rfcbot added finished-final-comment-period to-announce and removed final-comment-period labels Mar 8, 2025

rustbot mentioned this pull request Mar 8, 2025

Tracking issue for release notes of #136968: Turn order dependent trait objects future incompat warning into a hard error #138244

Open

bors added S-waiting-on-bors and removed S-waiting-on-author labels Mar 8, 2025

jieyouxu mentioned this pull request Mar 9, 2025

Rollup of 16 pull requests #138255

Closed

matthiaskrgr mentioned this pull request Mar 9, 2025

Rollup of 12 pull requests #138267

Merged

bors merged commit 5a46f82 into rust-lang:master Mar 9, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 9, 2025

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn order dependent trait objects future incompat warning into a hard error #136968

Turn order dependent trait objects future incompat warning into a hard error #136968

oli-obk commented Feb 13, 2025

oli-obk commented Feb 13, 2025

bors commented Feb 13, 2025

bors commented Feb 13, 2025

oli-obk commented Feb 13, 2025

craterbot commented Feb 13, 2025

craterbot commented Feb 13, 2025

craterbot commented Feb 14, 2025

oli-obk commented Feb 14, 2025

oli-obk commented Feb 25, 2025

rfcbot commented Feb 25, 2025 •

edited by jackh726

Loading

oli-obk commented Feb 25, 2025

nikomatsakis commented Feb 26, 2025

rfcbot commented Feb 26, 2025

compiler-errors commented Feb 28, 2025

rfcbot commented Mar 8, 2025

compiler-errors commented Mar 8, 2025

bors commented Mar 8, 2025

Kobzol commented Mar 9, 2025

This comment has been minimized.

rust-timer commented Mar 9, 2025

Turn order dependent trait objects future incompat warning into a hard error #136968

Turn order dependent trait objects future incompat warning into a hard error #136968

Conversation

oli-obk commented Feb 13, 2025

oli-obk commented Feb 13, 2025

bors commented Feb 13, 2025

bors commented Feb 13, 2025

oli-obk commented Feb 13, 2025

craterbot commented Feb 13, 2025

craterbot commented Feb 13, 2025

craterbot commented Feb 14, 2025

oli-obk commented Feb 14, 2025

oli-obk commented Feb 25, 2025

rfcbot commented Feb 25, 2025 • edited by jackh726 Loading

oli-obk commented Feb 25, 2025

nikomatsakis commented Feb 26, 2025

rfcbot commented Feb 26, 2025

compiler-errors commented Feb 28, 2025

rfcbot commented Mar 8, 2025

compiler-errors commented Mar 8, 2025

bors commented Mar 8, 2025

Kobzol commented Mar 9, 2025

This comment has been minimized.

rust-timer commented Mar 9, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

rfcbot commented Feb 25, 2025 •

edited by jackh726

Loading