Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Result::map_or_default and Option::map_or_default #138068

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Result::map_or_default and Option::map_or_default #138068

wants to merge 3 commits into from

Conversation

fpervaiz
Copy link

@fpervaiz fpervaiz commented Mar 5, 2025

Adds Result::map_or_default and Option::map_or_default as discussed extensively at rust-lang/rfcs#3148

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 5, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sky9x
Sky9x reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Sky9x Sky9x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need rfc approval or an ACP
also needs a tracking issue

implementation LGTM

@fpervaiz fpervaiz mentioned this pull request Mar 6, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sky9x Sky9x

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fpervaiz @rustbot @rust-log-analyzer @Sky9x @Amanieu