Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in hir lowering lint diag #138518

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Fix typo in hir lowering lint diag #138518

merged 2 commits into from
Mar 15, 2025

Conversation

yotamofek
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025
compiler-errors
compiler-errors requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz bless tests with ./x.py test ui --bless

Also, this is a kinda awkward note given the context, i wonder if it could use some further rewording 🤔

@compiler-errors
Copy link
Member

@rustbot author
r? compiler-errors

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@rustbot rustbot assigned compiler-errors and unassigned BoxyUwU Mar 14, 2025
@yotamofek
Copy link
Contributor Author

plz bless tests with ./x.py test ui --bless

Right, sorry, was too hasty.

Also, this is a kinda awkward note given the context, i wonder if it could use some further rewording 🤔

I agree that the phrasing isn't great.
What about:

`{trait_name}` is dyn-incompatible, otherwise a trait object could be used to accept any type that implements this trait

Too long, maybe?

@compiler-errors
Copy link
Member

compiler-errors commented Mar 14, 2025 •
edited
Loading

maybe just

[...] otherwise a trait object could be used

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@yotamofek
Copy link
Contributor Author

yotamofek commented Mar 14, 2025 •
edited
Loading

Updated diag text, and fixed a small grammar issue in an adjacent comment while I was at it
@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2025
@compiler-errors
Copy link
Member

a one-liner grammatical typo fix in a comment probably can just be folded into the first commit next time 🤔

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 14, 2025

📌 Commit e6f7ab5 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@fmease fmease mentioned this pull request Mar 14, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2025
@bors
Auto merge of rust-lang#138523 - fmease:rollup-j2j5h59, r=fmease
2828650 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#138056 (rustc_target: Add target features for LoongArch v1.1)
 - rust-lang#138451 (Build GCC on CI with GCC, not Clang)
 - rust-lang#138454 (Improve post-merge workflow)
 - rust-lang#138460 (Pass struct field HirId when check_expr_struct_fields)
 - rust-lang#138474 (Refactor is_snake_case.)
 - rust-lang#138482 (Fix HIR printing of parameters)
 - rust-lang#138507 (Mirror NetBSD sources)
 - rust-lang#138511 (Make `Parser::parse_expr_cond` public)
 - rust-lang#138518 (Fix typo in hir lowering lint diag)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 15, 2025
@rust-timer
Unrolled build for rust-lang#138518
67c9c90 
Rollup merge of rust-lang#138518 - yotamofek:pr/hir-lint-typo, r=compiler-errors

Fix typo in hir lowering lint diag
@bors bors merged commit 9838591 into rust-lang:master Mar 15, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 15, 2025
@yotamofek yotamofek deleted the pr/hir-lint-typo branch March 15, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yotamofek @rustbot @compiler-errors @rust-log-analyzer @bors @BoxyUwU