Move some driver code around #138786
Merged
Move some driver code around #138786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--emit mir`, `#[rustc_symbol_name]` and `#[rustc_def_path]` now run before codegen and thus work even if codegen fails. This can help with debugging.
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
| // Hook for UI tests. | ||
| check_for_rustc_errors_attr(tcx); | ||
|
|
||
| // Don't run this test assertions when not doing codegen. Compiletest tries to build |
There was a problem hiding this comment.
This comment feels misplaced 🤔
There was a problem hiding this comment.
Or at least I'm not seeing its point. Are the ui tests relying on //@ build-fail?
There was a problem hiding this comment.
Yes, the attributes in report_symbol_names emit errors so //@ build-fail is necessary, which requires a check build to pass, thus necessitating this pass not to run in check mode.
compiler-errors
approved these changes
Mar 21, 2025
| // Hook for UI tests. | ||
| check_for_rustc_errors_attr(tcx); | ||
|
|
||
| // Don't run this test assertions when not doing codegen. Compiletest tries to build |
There was a problem hiding this comment.
Or at least I'm not seeing its point. Are the ui tests relying on //@ build-fail?
compiler-errors
added
S-waiting-on-author
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#138018 (rustdoc: Use own logic to print `#[repr(..)]` attributes in JSON output.) - rust-lang#138294 (Mark some std tests as requiring `panic = "unwind"`) - rust-lang#138468 (rustdoc js: add nonnull helper and typecheck src-script.js) - rust-lang#138675 (Add release notes for 1.85.1) - rust-lang#138765 (Fix Thread::set_name on cygwin) - rust-lang#138786 (Move some driver code around) - rust-lang#138793 (target spec check: better error when llvm-floatabi is missing) - rust-lang#138822 (De-Stabilize `file_lock`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 23, 2025
Rollup merge of rust-lang#138786 - bjorn3:driver_code_move, r=compiler-errors Move some driver code around `--emit mir`, `#[rustc_symbol_name]` and `#[rustc_def_path]` now run before codegen and thus work even if codegen fails. This can help with debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--emit mir,#[rustc_symbol_name]and#[rustc_def_path]now run before codegen and thus work even if codegen fails. This can help with debugging.