Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Apple version handling in the compiler #138947

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Mar 25, 2025

Move various Apple version handling code in the compiler out rustc_codegen_ssa and into a place where it can be accessed by rustc_attr_parsing, which I found to be necessary when doing #136867. Thought I'd split it out to make it easier to land, and to make further changes like #131477 have fewer conflicts / PR dependencies.

There should be no functional changes in this PR.

@rustbot label O-apple
r? rust-lang/compiler

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

Failed to set assignee to t-compiler: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@madsmtm madsmtm changed the title Refactor Apple versions Refactor Apple version handling in the compiler Mar 25, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Mar 26, 2025

r? compiler

@rustbot rustbot assigned Noratrieb and unassigned BoxyUwU Mar 26, 2025
@madsmtm madsmtm force-pushed the refactor-apple-versions branch from babb63c to 39b5847 Compare March 26, 2025 17:51
@madsmtm madsmtm force-pushed the refactor-apple-versions branch from 39b5847 to 72b5ef0 Compare March 28, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants