Revert "Make MatchPairTree::place non-optional" #138959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e3e74bc. The comment that was used to justify the change was outdated.
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in match lowering cc @Nadrieril |
|
Thanks for taking care of this. @bors r+ rollup |
bors
added
S-waiting-on-bors
|
(The test could maybe use some comments, but I didn't want that to hold up the revert, so I approved it as-is.) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#138483 (Target modifiers fix for bool flags without value) - rust-lang#138818 (Don't produce debug information for compiler-introduced-vars when desugaring assignments.) - rust-lang#138898 (Mostly parser: Eliminate code that's been dead / semi-dead since the removal of type ascription syntax) - rust-lang#138930 (Add bootstrap step diff to CI job analysis) - rust-lang#138954 (Ensure `define_opaque` attrs are accounted for in HIR hash) - rust-lang#138959 (Revert "Make MatchPairTree::place non-optional") - rust-lang#138967 (Fix typo in error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2025
Rollup merge of rust-lang#138959 - meithecatte:matchpair-place-option, r=Zalathar Revert "Make MatchPairTree::place non-optional" Reverts a part of rust-lang#137875. Fixes rust-lang#138958. cc `@Zalathar`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a part of #137875. Fixes #138958.
cc @Zalathar