Clean up a few things in rustc_hir_analysis::check::region #138989
Conversation
They are unused.
There is no difference between the Patternand Borrow cases. Reduce it to a simple struct.
It was never used.
m-ou-se
added
C-cleanup
rustbot
added
the
S-waiting-on-review
|
@dingxiangfei2009 I think you are familiar with this code. |
|
I would like to throw in my 👍 as well. The plan to expand |
|
Could you document in which case var_parent and parent are unequal? We figured out this was in |
|
There are many points at which var_parent and parent are unequal. In an |
|
But that's not really the point of this PR anyway. |
|
alright, I see. After some (offline) discussion there indeed seems more at play here than if let. The summary was: the difference between these two variables seems to affect more than just if-let and these changes clean some things up on their own which seems good for now). Documenting (or changing) the exact difference here can be something for later, but this seems ok on its own then. @bors r=jdonszelmann,dingxiangfei2009 rollup |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#138844 (expand: Leave traces when expanding `cfg` attributes) - rust-lang#138926 (Remove `kw::Empty` uses from `rustc_middle`.) - rust-lang#138989 (Clean up a few things in rustc_hir_analysis::check::region) - rust-lang#138999 (Report compiletest pass mode if forced) - rust-lang#139014 (Improve suggest construct with literal syntax instead of calling) - rust-lang#139015 (Remove unneeded LLVM CI test assertions) - rust-lang#139016 (Add job duration changes to post-merge analysis report) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#138989 - m-ou-se:clean-up-things, r=jdonszelmann,dingxiangfei2009 Clean up a few things in rustc_hir_analysis::check::region Each commit is independent. They are all small clean-ups in rustc_hir_analysis::check::region.
Each commit is independent. They are all small clean-ups in rustc_hir_analysis::check::region.