Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: Avoid cloning change-id list #139044

Merged
merged 1 commit into from
Mar 31, 2025
Merged

bootstrap: Avoid cloning change-id list #139044

merged 1 commit into from
Mar 31, 2025
+11 −15

Conversation

thaliaarchi
Copy link
Contributor

@thaliaarchi thaliaarchi commented Mar 28, 2025 •
edited
Loading

Inspired by recent discussion on the bootstrap change-id field, I took a look at the code and found this little optimization. It does not change behavior.

@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2025

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 28, 2025
onur-ozkan
onur-ozkan approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good improvement!

Waiting for the CI to turn green.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan
Copy link
Member

There is a linting error.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025
@thaliaarchi thaliaarchi force-pushed the bootstrap-change-id-clone branch from 4f506f5 to ad29f94 Compare March 28, 2025 06:45
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 28, 2025

📌 Commit ad29f94 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2025
@Kobzol
Copy link
Contributor

Kobzol commented Mar 28, 2025

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Mar 28, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
@bors
Auto merge of rust-lang#139054 - matthiaskrgr:rollup-2bk2fb4, r=matth…
afaa656 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#137889 (update outdated doc with new example)
 - rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
 - rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
 - rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
 - rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
 - rust-lang#139045 (bootstrap: update `test_find` test)
 - rust-lang#139047 (Remove ScopeDepth)

Failed merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
@bors
Auto merge of rust-lang#139054 - matthiaskrgr:rollup-2bk2fb4, r=matth…
19f42cb 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#137889 (update outdated doc with new example)
 - rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
 - rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
 - rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
 - rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
 - rust-lang#139045 (bootstrap: update `test_find` test)
 - rust-lang#139047 (Remove ScopeDepth)

Failed merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 28, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2025
@bors
Auto merge of rust-lang#139085 - matthiaskrgr:rollup-3q2peol, r=matth…
920d95e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138976 (Explain one-past-the-end pointer in std library)
 - rust-lang#139052 (Put pin!() tests in the right file.)
 - rust-lang#139058 (Fix formatting nit in process.rs)
 - rust-lang#139063 (Fix TAIT & ATPIT feature gating in the presence of anon consts)
 - rust-lang#139065 (Miri subtree update)
 - rust-lang#139069 (`io::Take`: avoid new `BorrowedBuf` creation in some case)
 - rust-lang#139075 (Do not treat lifetimes from parent items as influencing child items)
 - rust-lang#139079 (tracking autodiff files via triagebot.toml)

Failed merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Mar 28, 2025

☔ The latest upstream changes (presumably #139054) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2025
@thaliaarchi thaliaarchi force-pushed the bootstrap-change-id-clone branch from ad29f94 to fbe5e55 Compare March 28, 2025 21:46
@thaliaarchi
Copy link
Contributor Author

So it did conflict with #138986. Rebased.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 28, 2025

@bors r=onur-ozkan

@bors
Copy link
Collaborator

bors commented Mar 28, 2025

📌 Commit fbe5e55 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 29, 2025
@jhpratt
Rollup merge of rust-lang#139044 - thaliaarchi:bootstrap-change-id-cl…
3d2282e 
…one, r=onur-ozkan

bootstrap: Avoid cloning `change-id` list

Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.
@jhpratt jhpratt mentioned this pull request Mar 29, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2025
@bors
Auto merge of rust-lang#139094 - jhpratt:rollup-usgpag3, r=jhpratt
31ded84 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#138692 (Reject `{true,false}` as revision names)
 - rust-lang#138757 (wasm: increase default thread stack size to 1 MB)
 - rust-lang#138832 (Start using `with_native_path` in `std::sys::fs`)
 - rust-lang#138988 (Change the syntax of the internal `weak!` macro)
 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)
 - rust-lang#139056 (use `try_fold` instead of `fold`)
 - rust-lang#139057 (use `slice::contains` where applicable)
 - rust-lang#139086 (Various cleanup in ExprUseVisitor)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 29, 2025
@jhpratt
Rollup merge of rust-lang#139044 - thaliaarchi:bootstrap-change-id-cl…
580bab2 
…one, r=onur-ozkan

bootstrap: Avoid cloning `change-id` list

Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.
@jhpratt jhpratt mentioned this pull request Mar 29, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2025
@bors
Auto merge of rust-lang#139096 - jhpratt:rollup-nfyct4q, r=jhpratt
ef8b5e1 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#138692 (Reject `{true,false}` as revision names)
 - rust-lang#138757 (wasm: increase default thread stack size to 1 MB)
 - rust-lang#138988 (Change the syntax of the internal `weak!` macro)
 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)
 - rust-lang#139056 (use `try_fold` instead of `fold`)
 - rust-lang#139057 (use `slice::contains` where applicable)
 - rust-lang#139086 (Various cleanup in ExprUseVisitor)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 30, 2025
@jhpratt
Rollup merge of rust-lang#139044 - thaliaarchi:bootstrap-change-id-cl…
45f013e 
…one, r=onur-ozkan

bootstrap: Avoid cloning `change-id` list

Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.
@jhpratt jhpratt mentioned this pull request Mar 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2025
@bors
Auto merge of rust-lang#139126 - jhpratt:rollup-tdceqkd, r=jhpratt
86f98f1 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#137836 (Set `target_vendor = "openwrt"` on `mips64-openwrt-linux-musl`)
 - rust-lang#138206 ([AIX] Ignore linting on repr(C) structs with repr(packed) or repr(align(n)))
 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)
 - rust-lang#139092 (Move `fd` into `std::sys`)
 - rust-lang#139111 (Properly document FakeReads)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 30, 2025
@jhpratt
Rollup merge of rust-lang#139044 - thaliaarchi:bootstrap-change-id-cl…
ea17854 
…one, r=onur-ozkan

bootstrap: Avoid cloning `change-id` list

Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.
@jhpratt jhpratt mentioned this pull request Mar 30, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2025
@bors
Auto merge of rust-lang#139147 - jhpratt:rollup-2o5l63n, r=jhpratt
07c1d0a 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)
 - rust-lang#139111 (Properly document FakeReads)
 - rust-lang#139113 (unstable book: in a sanitizer example, check the code)
 - rust-lang#139122 (Remove attribute `#[rustc_error]`)
 - rust-lang#139132 (Improve hir_pretty for struct expressions.)
 - rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented)

r? `@ghost`
`@rustbot` modify labels: rollup
@jhpratt jhpratt mentioned this pull request Mar 30, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2025
@bors
Auto merge of rust-lang#139154 - jhpratt:rollup-rv8f915, r=jhpratt
3c0f722 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list)
 - rust-lang#139111 (Properly document FakeReads)
 - rust-lang#139122 (Remove attribute `#[rustc_error]`)
 - rust-lang#139132 (Improve hir_pretty for struct expressions.)
 - rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4cfcafd into rust-lang:master Mar 31, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Mar 31, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2025
@rust-timer
Unrolled build for rust-lang#139044
2b1b2ac 
Rollup merge of rust-lang#139044 - thaliaarchi:bootstrap-change-id-clone, r=onur-ozkan

bootstrap: Avoid cloning `change-id` list

Inspired by [recent discussion](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Collecting.20some.20Real.20Configs.20for.20testing/near/507845657) on the bootstrap `change-id` field, I took a look at the code and found this little optimization. It does not change behavior.
@thaliaarchi thaliaarchi deleted the bootstrap-change-id-clone branch March 31, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan

Assignees

@onur-ozkan onur-ozkan

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thaliaarchi @rustbot @rust-log-analyzer @onur-ozkan @bors @Kobzol