Skip to content

Upgrade to ndarray 0.16 #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Conversation

relf
Copy link
Member

@relf relf commented Jan 29, 2025

  • ndarray 0.16
  • linfa-llinalg 0.2
  • narray-linalg 0.17
  • ndarray-stats 0.6
  • ndarray-rand 0.15
  • ndarray-csv 0.5
  • sprs 0.11
  • approx 0.5
  • argmin > 0.10.0
  • argmin-math > 0.4.0
  • criterion 0.5
  • statrs 0.18
  • thiserror 2.0

@jonhoo jonhoo mentioned this pull request Mar 3, 2025
@relf relf force-pushed the upgrade-ndarray-0.16 branch from 70bee1d to d9ec0ec Compare March 10, 2025 14:37
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.66%. Comparing base (5272ad1) to head (52fe1a7).

Files with missing lines Patch % Lines
src/composing/multi_target_model.rs 33.33% 4 Missing ⚠️
algorithms/linfa-logistic/src/lib.rs 75.00% 2 Missing ⚠️
src/dataset/impl_dataset.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   35.90%   35.66%   -0.24%     
==========================================
  Files          97       96       -1     
  Lines        6409     6410       +1     
==========================================
- Hits         2301     2286      -15     
- Misses       4108     4124      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amfaber
Copy link

amfaber commented Apr 1, 2025

Is anything blocking this other than the release of a new version of argmin that supports ndarray 0.16?

@relf relf force-pushed the upgrade-ndarray-0.16 branch from aee5070 to 52fe1a7 Compare April 1, 2025 08:09
@relf
Copy link
Member Author

relf commented Apr 1, 2025

Is anything blocking this other than the release of a new version of argmin that supports ndarray 0.16?

No. The PR is currently tested against argmin master. AFAIK, argmin's maintainer will release a new version in a few weeks.

@amfaber
Copy link

amfaber commented Apr 1, 2025

Fantastic! Thanks for the quick response :)

@shigedangao
Copy link

Any update on that PR ?

@relf
Copy link
Member Author

relf commented May 19, 2025

Any update on that PR ?

Nope... Still waiting for argmin new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants