-
-
Notifications
You must be signed in to change notification settings - Fork 279
linfa-preprocessing::countgrams: RefCell is replaced with OnceLock #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
linfa-preprocessing::countgrams: RefCell is replaced with OnceLock #387
Conversation
|
@relf I don't quite understand what you mean by that. |
With I meant you can just clone |
@relf Well, I guess we could solve the issue by implementing serialize and deserialize manually, right? |
Maybe... But there is no problem in the first place if you just clone |
@relf please review the updated version. |
24449de
to
776e311
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 35.90% 36.17% +0.26%
==========================================
Files 97 101 +4
Lines 6409 6563 +154
==========================================
+ Hits 2301 2374 +73
- Misses 4108 4189 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simple fix to allow for concurrent access.