Customizable MySQL implementation

Test Plan:
- /
- upgrade_schema.php
- Setup
- Try disabling mysql_connect.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2133

Author: vrana

conf/default.conf.php

@@ -120,6 +120,11 @@
   // The number of times to try reconnecting to the MySQL database
   'mysql.connection-retries' => 3,
 
+  // Phabricator supports PHP extensions MySQL and MySQLi. It is possible to
+  // implement also other access mechanism (e.g. PDO_MySQL). The class must
+  // extend AphrontMySQLDatabaseConnectionBase.
+  'mysql.implementation' => 'AphrontMySQLDatabaseConnection',
+
 
 // -- Email ----------------------------------------------------------------- //
 

scripts/sql/upgrade_schema.php

@@ -83,12 +83,15 @@
   $conn_bare_hostname = $conn_host;
 }
 
-$conn = new AphrontMySQLDatabaseConnection(
+$conn = PhabricatorEnv::newObjectFromConfig(
+  'mysql.implementation',
   array(
-    'user'      => $conn_user,
-    'pass'      => $conn_pass,
-    'host'      => $conn_host,
-    'database'  => null,
+    array(
+      'user'      => $conn_user,
+      'pass'      => $conn_pass,
+      'host'      => $conn_host,
+      'database'  => null,
+    ),
   ));
 
 try {

src/aphront/console/plugin/services/DarkConsoleServicesPlugin.php

@@ -55,7 +55,9 @@ public function generateData() {
       // For each SELECT query, go issue an EXPLAIN on it so we can flag stuff
       // causing table scans, etc.
       if (preg_match('/^\s*SELECT\b/i', $entry['query'])) {
-        $conn = new AphrontMySQLDatabaseConnection($entry['config']);
+        $conn = PhabricatorEnv::newObjectFromConfig(
+          'mysql.implementation',
+          array($entry['config']));
         try {
           $explain = queryfx_all(
             $conn,

src/aphront/console/plugin/services/__init__.php

@@ -7,7 +7,7 @@
 
 
 phutil_require_module('phabricator', 'aphront/console/plugin/base');
-phutil_require_module('phabricator', 'storage/connection/mysql/mysql');
+phutil_require_module('phabricator', 'infrastructure/env');
 phutil_require_module('phabricator', 'storage/queryfx');
 phutil_require_module('phabricator', 'view/control/table');
 

src/applications/base/storage/lisk/PhabricatorLiskDAO.php

@@ -71,12 +71,15 @@ public function establishLiveConnection($mode) {
     PhutilSymbolLoader::loadClass($conf_provider);
     $conf = newv($conf_provider, array($this, $mode));
 
-    return new AphrontMySQLDatabaseConnection(
+    return PhabricatorEnv::newObjectFromConfig(
+      'mysql.implementation',
       array(
-        'user'      => $conf->getUser(),
-        'pass'      => $conf->getPassword(),
-        'host'      => $conf->getHost(),
-        'database'  => $conf->getDatabase(),
+        array(
+          'user'      => $conf->getUser(),
+          'pass'      => $conf->getPassword(),
+          'host'      => $conf->getHost(),
+          'database'  => $conf->getDatabase(),
+        ),
       ));
   }
 

src/applications/base/storage/lisk/__init__.php

@@ -7,7 +7,6 @@
 
 
 phutil_require_module('phabricator', 'infrastructure/env');
-phutil_require_module('phabricator', 'storage/connection/mysql/mysql');
 phutil_require_module('phabricator', 'storage/lisk/dao');
 
 phutil_require_module('phutil', 'symbols');

src/infrastructure/env/PhabricatorEnv.php

@@ -55,6 +55,7 @@ public static function getRequiredClasses() {
         'AphrontApplicationConfiguration',
       'controller.oauth-registration' =>
         'PhabricatorOAuthRegistrationController',
+      'mysql.implementation' => 'AphrontMySQLDatabaseConnectionBase',
       'differential.attach-task-class' => 'DifferentialTasksAttacher',
     );
   }

src/infrastructure/setup/PhabricatorSetup.php

@@ -473,12 +473,15 @@ public static function runSetup() {
 
     ini_set('mysql.connect_timeout', 2);
 
-    $conn_raw = new AphrontMySQLDatabaseConnection(
+    $conn_raw = PhabricatorEnv::newObjectFromConfig(
+      'mysql.implementation',
       array(
-        'user'      => $conn_user,
-        'pass'      => $conn_pass,
-        'host'      => $conn_host,
-        'database'  => null,
+        array(
+          'user'      => $conn_user,
+          'pass'      => $conn_pass,
+          'host'      => $conn_host,
+          'database'  => null,
+        ),
       ));
 
     try {

src/infrastructure/setup/__init__.php

@@ -9,7 +9,6 @@
 phutil_require_module('phabricator', 'applications/base/storage/configuration');
 phutil_require_module('phabricator', 'infrastructure/env');
 phutil_require_module('phabricator', 'infrastructure/setup/sql');
-phutil_require_module('phabricator', 'storage/connection/mysql/mysql');
 phutil_require_module('phabricator', 'storage/queryfx');
 
 phutil_require_module('phutil', 'filesystem');

webroot/index.php

@@ -46,11 +46,6 @@
     "is one of 'development', 'production', or a custom environment.");
 }
 
-if (!function_exists('mysql_connect')) {
-  phabricator_fatal_config_error(
-    "The PHP MySQL extension is not installed. This extension is required.");
-}
-
 if (!isset($_REQUEST['__path__'])) {
   phabricator_fatal_config_error(
     "__path__ is not set. Your rewrite rules are not configured correctly.");