Skip to content

Commit ea6d2af

Browse files
author
epriestley
committedNov 15, 2018
Fix flickering tooltips in Chrome when the tip container overlaps the triggering element
Summary: Fixes T8440. See that task for discussion. Ref T13216. See PHI976. Test Plan: In Chrome, hovered a timestamp and moved the mouse up to the "overlap" area (see T8440). Before: flickered like crazy. After: no flickering. (I couldn't reproduce the original issue in modern Firefox or Safari.) Reviewers: amckinley, avivey Reviewed By: avivey Maniphest Tasks: T8440, T13216 Differential Revision: https://secure.phabricator.com/D19808
1 parent e57bfbf commit ea6d2af

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => 'e68cf1fa',
1111
'conpherence.pkg.js' => '15191c65',
12-
'core.pkg.css' => '2574c199',
12+
'core.pkg.css' => 'cff4ff6f',
1313
'core.pkg.js' => 'b5a949ca',
1414
'differential.pkg.css' => '06dc617c',
1515
'differential.pkg.js' => 'c1cfa143',
@@ -32,7 +32,7 @@
3232
'rsrc/css/aphront/phabricator-nav-view.css' => '694d7723',
3333
'rsrc/css/aphront/table-view.css' => '8c9bbafe',
3434
'rsrc/css/aphront/tokenizer.css' => '15d5ff71',
35-
'rsrc/css/aphront/tooltip.css' => '173b9431',
35+
'rsrc/css/aphront/tooltip.css' => 'cb1397a4',
3636
'rsrc/css/aphront/typeahead-browse.css' => 'f2818435',
3737
'rsrc/css/aphront/typeahead.css' => 'a4a21016',
3838
'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
@@ -521,7 +521,7 @@
521521
'aphront-panel-view-css' => '8427b78d',
522522
'aphront-table-view-css' => '8c9bbafe',
523523
'aphront-tokenizer-control-css' => '15d5ff71',
524-
'aphront-tooltip-css' => '173b9431',
524+
'aphront-tooltip-css' => 'cb1397a4',
525525
'aphront-typeahead-control-css' => 'a4a21016',
526526
'application-search-view-css' => '787f5b76',
527527
'auth-css' => '0877ed6e',

‎webroot/rsrc/css/aphront/tooltip.css

+6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@
55
.jx-tooltip-container {
66
position: absolute;
77
padding: 5px;
8+
9+
/* In Chrome, moving the cursor into the empty space next to the "caret" on
10+
the caret side of the tooltip can cause the tooltip to flicker rapidly
11+
because the cursor hits the container. To stop this, prevent cursor
12+
events on the container. See T8440. */
13+
pointer-events: none;
814
}
915

1016
.jx-tooltip-appear {

0 commit comments

Comments
 (0)
Failed to load comments.