Skip to content

Commit cb055e5

Browse files
committed
[libc++] Add a CI job running MSAN
For some reason, we've been going without a MSAN CI job, even though even run-buildbot defined a generic-msan job. This must have been an oversight that went unnoticed. Thanks to @EricWF for the catch. Differential Revision: https://reviews.llvm.org/D120851
1 parent 7f07600 commit cb055e5

8 files changed

+36
-0
lines changed

libcxx/utils/ci/buildkite-pipeline.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,20 @@ steps:
276276
limit: 2
277277
timeout_in_minutes: 120
278278

279+
- label: "MSAN"
280+
command: "libcxx/utils/ci/run-buildbot generic-msan"
281+
artifact_paths:
282+
- "**/test-results.xml"
283+
- "**/*.abilist"
284+
agents:
285+
queue: "libcxx-builders"
286+
os: "linux"
287+
retry:
288+
automatic:
289+
- exit_status: -1 # Agent was lost
290+
limit: 2
291+
timeout_in_minutes: 120
292+
279293
# Tests with the various supported ways to build libc++.
280294
- label: "Bootstrapping build"
281295
command: "libcxx/utils/ci/run-buildbot bootstrapping-build"

libunwind/test/forceunwind.pass.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99

1010
// REQUIRES: linux
1111

12+
// TODO: Figure out why this fails with Memory Sanitizer.
13+
// XFAIL: msan
14+
1215
// Basic test for _Unwind_ForcedUnwind.
1316
// See libcxxabi/test/forced_unwind* tests too.
1417

libunwind/test/libunwind_01.pass.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// TODO: Investigate these failures on x86_64 macOS back deployment
22
// UNSUPPORTED: target=x86_64-apple-darwin{{.+}}
33

4+
// TODO: Figure out why this fails with Memory Sanitizer.
5+
// XFAIL: msan
6+
47
#include <libunwind.h>
58
#include <stdlib.h>
69
#include <string.h>

libunwind/test/libunwind_02.pass.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// TODO: Figure out why this fails with Memory Sanitizer.
2+
// XFAIL: msan
3+
14
#include <assert.h>
25
#include <stdlib.h>
36
#include <unwind.h>

libunwind/test/remember_state_leak.pass.sh.s

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
# REQUIRES: target={{x86_64-.+-linux-gnu}}
2+
3+
// Inline assembly isn't supported by Memory Sanitizer
4+
// UNSUPPORTED: msan
5+
26
# RUN: %{build} -no-pie
37
# RUN: %{run}
48

libunwind/test/signal_frame.pass.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
// TODO: Investigate this failure on macOS
1313
// XFAIL: target={{.+}}-apple-darwin{{.+}}
1414

15+
// TODO: Figure out why this fails with Memory Sanitizer.
16+
// XFAIL: msan
17+
1518
// UNSUPPORTED: libunwind-arm-ehabi
1619

1720
// The AIX assembler does not support CFI directives, which

libunwind/test/signal_unwind.pass.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
// Ensure that the unwinder can cope with the signal handler.
1111
// REQUIRES: linux && (target={{aarch64-.+}} || target={{x86_64-.+}})
1212

13+
// TODO: Figure out why this fails with Memory Sanitizer.
14+
// XFAIL: msan
15+
1316
#include <assert.h>
1417
#include <dlfcn.h>
1518
#include <signal.h>

libunwind/test/unwind_leaffunction.pass.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
// Ensure that leaf function can be unwund.
1111
// REQUIRES: linux && (target={{aarch64-.+}} || target={{x86_64-.+}})
1212

13+
// TODO: Figure out why this fails with Memory Sanitizer.
14+
// XFAIL: msan
15+
1316
#include <assert.h>
1417
#include <dlfcn.h>
1518
#include <signal.h>

0 commit comments

Comments
 (0)