Conpherence - add back in custom images

Summary: Fixes T7254. This reverts the previous functionality, but makes pertinent updates like scaling the images to 35 x 35. Codebase had moved on quite a bit so far from a straight revert but nothing too tricky relative to the code that was here before. This does not allow for changing the images from the conpherence durable column view -- that would require some JS trickery, but also doesn't fit into the current notion of the column being "light". Can always modify this later.

Test Plan:
 - from full conpherence, uploaded a square pic and things looked nice
 - from full conpherence, uploaded a rectangular pic and wasnt happy, so reinvoked edit dialog and used crop control to make it better
 - noted could not update picture from conpherence durable column
 - used different user and noted could see custom picture

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: CodeMouse92, Korvin, epriestley

Maniphest Tasks: T7254

Differential Revision: https://secure.phabricator.com/D12648

Author: bobtrahan

resources/celerity/map.php

@@ -356,6 +356,7 @@
     'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
     'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
     'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '6709c934',
+    'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
     'rsrc/js/application/conpherence/behavior-durable-column.js' => '657c2b50',
     'rsrc/js/application/conpherence/behavior-menu.js' => '804b0773',
     'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
@@ -561,6 +562,7 @@
     'javelin-behavior-audit-preview' => 'd835b03a',
     'javelin-behavior-choose-control' => '6153c708',
     'javelin-behavior-config-reorder-fields' => '14a827de',
+    'javelin-behavior-conpherence-drag-and-drop-photo' => 'cf86d16a',
     'javelin-behavior-conpherence-menu' => '804b0773',
     'javelin-behavior-conpherence-pontificate' => '21ba5861',
     'javelin-behavior-conpherence-widget-pane' => '93568464',
@@ -1789,6 +1791,12 @@
       'javelin-stratcom',
       'phabricator-phtize',
     ),
+    'cf86d16a' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-workflow',
+      'phabricator-drag-and-drop-file-upload',
+    ),
     'd19198c8' => array(
       'javelin-install',
       'javelin-dom',

resources/sql/autopatches/20150501.conpherencepics.sql

@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread
+  ADD imagePHIDs LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL AFTER title;
+
+UPDATE {$NAMESPACE}_conpherence.conpherence_thread
+  SET imagePHIDS = '[]';

src/__phutil_library_map__.php

@@ -230,8 +230,10 @@
     'ConpherenceDurableColumnView' => 'applications/conpherence/view/ConpherenceDurableColumnView.php',
     'ConpherenceEditor' => 'applications/conpherence/editor/ConpherenceEditor.php',
     'ConpherenceFileWidgetView' => 'applications/conpherence/view/ConpherenceFileWidgetView.php',
+    'ConpherenceFormDragAndDropUploadControl' => 'applications/conpherence/view/ConpherenceFormDragAndDropUploadControl.php',
     'ConpherenceFulltextQuery' => 'applications/conpherence/query/ConpherenceFulltextQuery.php',
     'ConpherenceHovercardEventListener' => 'applications/conpherence/events/ConpherenceHovercardEventListener.php',
+    'ConpherenceImageData' => 'applications/conpherence/constants/ConpherenceImageData.php',
     'ConpherenceIndex' => 'applications/conpherence/storage/ConpherenceIndex.php',
     'ConpherenceLayoutView' => 'applications/conpherence/view/ConpherenceLayoutView.php',
     'ConpherenceListController' => 'applications/conpherence/controller/ConpherenceListController.php',
@@ -244,6 +246,7 @@
     'ConpherenceParticipantQuery' => 'applications/conpherence/query/ConpherenceParticipantQuery.php',
     'ConpherenceParticipationStatus' => 'applications/conpherence/constants/ConpherenceParticipationStatus.php',
     'ConpherencePeopleWidgetView' => 'applications/conpherence/view/ConpherencePeopleWidgetView.php',
+    'ConpherencePicCropControl' => 'applications/conpherence/view/ConpherencePicCropControl.php',
     'ConpherenceQueryThreadConduitAPIMethod' => 'applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php',
     'ConpherenceQueryTransactionConduitAPIMethod' => 'applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php',
     'ConpherenceReplyHandler' => 'applications/conpherence/mail/ConpherenceReplyHandler.php',
@@ -3467,8 +3470,10 @@
     'ConpherenceDurableColumnView' => 'AphrontTagView',
     'ConpherenceEditor' => 'PhabricatorApplicationTransactionEditor',
     'ConpherenceFileWidgetView' => 'ConpherenceWidgetView',
+    'ConpherenceFormDragAndDropUploadControl' => 'AphrontFormControl',
     'ConpherenceFulltextQuery' => 'PhabricatorOffsetPagedQuery',
     'ConpherenceHovercardEventListener' => 'PhabricatorEventListener',
+    'ConpherenceImageData' => 'ConpherenceConstants',
     'ConpherenceIndex' => 'ConpherenceDAO',
     'ConpherenceLayoutView' => 'AphrontView',
     'ConpherenceListController' => 'ConpherenceController',
@@ -3481,6 +3486,7 @@
     'ConpherenceParticipantQuery' => 'PhabricatorOffsetPagedQuery',
     'ConpherenceParticipationStatus' => 'ConpherenceConstants',
     'ConpherencePeopleWidgetView' => 'ConpherenceWidgetView',
+    'ConpherencePicCropControl' => 'AphrontFormControl',
     'ConpherenceQueryThreadConduitAPIMethod' => 'ConpherenceConduitAPIMethod',
     'ConpherenceQueryTransactionConduitAPIMethod' => 'ConpherenceConduitAPIMethod',
     'ConpherenceReplyHandler' => 'PhabricatorMailReplyHandler',

src/applications/conpherence/constants/ConpherenceImageData.php

@@ -0,0 +1,11 @@
+<?php
+
+final class ConpherenceImageData extends ConpherenceConstants {
+
+  const SIZE_ORIG = 'original';
+  const SIZE_CROP = 'crop';
+
+  const CROP_WIDTH = 35;
+  const CROP_HEIGHT = 35;
+
+}

src/applications/conpherence/constants/ConpherenceTransactionType.php

@@ -6,8 +6,6 @@ final class ConpherenceTransactionType extends ConpherenceConstants {
   const TYPE_TITLE           = 'title';
   const TYPE_PARTICIPANTS    = 'participants';
   const TYPE_DATE_MARKER     = 'date-marker';
-
-  /* these two are deprecated but keep them around for legacy installs */
   const TYPE_PICTURE         = 'picture';
   const TYPE_PICTURE_CROP    = 'picture-crop';
 

src/applications/conpherence/controller/ConpherenceColumnViewController.php

@@ -16,6 +16,7 @@ public function handleRequest(AphrontRequest $request) {
       $latest_conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs($conpherence_phids)
+        ->needCropPics(true)
         ->needParticipantCache(true)
         ->execute();
       $latest_conpherences = mpull($latest_conpherences, null, 'getPHID');
@@ -30,6 +31,7 @@ public function handleRequest(AphrontRequest $request) {
       $conpherence = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withIDs(array($request->getInt('id')))
+        ->needCropPics(true)
         ->needTransactions(true)
         ->setTransactionLimit(ConpherenceThreadQuery::TRANSACTION_LIMIT)
         ->executeOne();
@@ -39,6 +41,7 @@ public function handleRequest(AphrontRequest $request) {
       $conpherence = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs(array($participant->getConpherencePHID()))
+        ->needCropPics(true)
         ->needTransactions(true)
         ->setTransactionLimit(ConpherenceThreadQuery::TRANSACTION_LIMIT)
         ->executeOne();

src/applications/conpherence/controller/ConpherenceListController.php

@@ -138,6 +138,7 @@ private function loadConpherenceThreadData($participation) {
       $conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs($conpherence_phids)
+        ->needCropPics(true)
         ->needParticipantCache(true)
         ->execute();
 

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

@@ -17,6 +17,7 @@ public function handleRequest(AphrontRequest $request) {
       $conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs(array_keys($participant_data))
+        ->needCropPics(true)
         ->needTransactions(true)
         ->setTransactionLimit(3 * 5)
         ->needParticipantCache(true)

src/applications/conpherence/controller/ConpherenceUpdateController.php

@@ -37,6 +37,8 @@ public function handleRequest(AphrontRequest $request) {
       ->setViewer($user)
       ->withIDs(array($conpherence_id))
       ->needFilePHIDs(true)
+      ->needOrigPics(true)
+      ->needCropPics(true)
       ->needParticipants($need_participants)
       ->requireCapabilities($needed_capabilities)
       ->executeOne();
@@ -132,11 +134,56 @@ public function handleRequest(AphrontRequest $request) {
             ->setContent($result);
           break;
         case ConpherenceUpdateActions::METADATA:
-          // all metadata updates are continue requests
+          $top = $request->getInt('image_y');
+          $left = $request->getInt('image_x');
+          $file_id = $request->getInt('file_id');
+          $title = $request->getStr('title');
+          if ($file_id) {
+            $orig_file = id(new PhabricatorFileQuery())
+              ->setViewer($user)
+              ->withIDs(array($file_id))
+              ->executeOne();
+            $xactions[] = id(new ConpherenceTransaction())
+              ->setTransactionType(ConpherenceTransactionType::TYPE_PICTURE)
+              ->setNewValue($orig_file);
+            $okay = $orig_file->isTransformableImage();
+            if ($okay) {
+              $xformer = new PhabricatorImageTransformer();
+              $crop_file = $xformer->executeConpherenceTransform(
+                $orig_file,
+                0,
+                0,
+                ConpherenceImageData::CROP_WIDTH,
+                ConpherenceImageData::CROP_HEIGHT);
+              $xactions[] = id(new ConpherenceTransaction())
+                ->setTransactionType(
+                  ConpherenceTransactionType::TYPE_PICTURE_CROP)
+                ->setNewValue($crop_file->getPHID());
+            }
+            $response_mode = 'redirect';
+          }
+
+          // all other metadata updates are continue requests
           if (!$request->isContinueRequest()) {
             break;
           }
 
+          if ($top !== null || $left !== null) {
+            $file = $conpherence->getImage(ConpherenceImageData::SIZE_ORIG);
+            $xformer = new PhabricatorImageTransformer();
+            $xformed = $xformer->executeConpherenceTransform(
+              $file,
+              $top,
+              $left,
+              ConpherenceImageData::CROP_WIDTH,
+              ConpherenceImageData::CROP_HEIGHT);
+            $image_phid = $xformed->getPHID();
+
+            $xactions[] = id(new ConpherenceTransaction())
+              ->setTransactionType(
+                ConpherenceTransactionType::TYPE_PICTURE_CROP)
+              ->setNewValue($image_phid);
+          }
           $title = $request->getStr('title');
           $xactions[] = id(new ConpherenceTransaction())
             ->setTransactionType(ConpherenceTransactionType::TYPE_TITLE)
@@ -323,6 +370,35 @@ private function renderMetadataDialogue(
         ->setName('title')
         ->setValue($conpherence->getTitle()));
 
+    $nopic = $this->getRequest()->getExists('nopic');
+    $image = $conpherence->getImage(ConpherenceImageData::SIZE_ORIG);
+    if ($nopic) {
+      // do not render any pic related controls
+    } else if ($image) {
+      $crop_uri = $conpherence->loadImageURI(ConpherenceImageData::SIZE_CROP);
+      $form
+        ->appendChild(
+          id(new AphrontFormMarkupControl())
+          ->setLabel(pht('Image'))
+          ->setValue(phutil_tag(
+            'img',
+            array(
+              'src' => $crop_uri,
+              ))))
+        ->appendChild(
+          id(new ConpherencePicCropControl())
+          ->setLabel(pht('Crop Image'))
+          ->setValue($image))
+        ->appendChild(
+          id(new ConpherenceFormDragAndDropUploadControl())
+          ->setLabel(pht('Change Image')));
+    } else {
+      $form
+        ->appendChild(
+          id(new ConpherenceFormDragAndDropUploadControl())
+          ->setLabel(pht('Image')));
+    }
+
     if ($conpherence->getIsRoom()) {
       $title = pht('Update Room');
       $policies = id(new PhabricatorPolicyQuery())
@@ -400,6 +476,7 @@ private function loadAndRenderUpdates(
     $conpherence = id(new ConpherenceThreadQuery())
       ->setViewer($user)
       ->setAfterTransactionID($latest_transaction_id)
+      ->needCropPics(true)
       ->needParticipantCache($need_participant_cache)
       ->needWidgetData($need_widget_data)
       ->needTransactions($need_transactions)

src/applications/conpherence/controller/ConpherenceViewController.php

@@ -15,6 +15,7 @@ public function handleRequest(AphrontRequest $request) {
     $query = id(new ConpherenceThreadQuery())
       ->setViewer($user)
       ->withIDs(array($conpherence_id))
+      ->needCropPics(true)
       ->needParticipantCache(true)
       ->needTransactions(true)
       ->setTransactionLimit($this->getMainQueryLimit());

src/applications/conpherence/editor/ConpherenceEditor.php

@@ -120,6 +120,8 @@ public function getTransactionTypes() {
     $types[] = ConpherenceTransactionType::TYPE_TITLE;
     $types[] = ConpherenceTransactionType::TYPE_PARTICIPANTS;
     $types[] = ConpherenceTransactionType::TYPE_FILES;
+    $types[] = ConpherenceTransactionType::TYPE_PICTURE;
+    $types[] = ConpherenceTransactionType::TYPE_PICTURE_CROP;
     $types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
     $types[] = PhabricatorTransactions::TYPE_EDIT_POLICY;
     $types[] = PhabricatorTransactions::TYPE_JOIN_POLICY;
@@ -134,6 +136,10 @@ protected function getCustomTransactionOldValue(
     switch ($xaction->getTransactionType()) {
       case ConpherenceTransactionType::TYPE_TITLE:
         return $object->getTitle();
+      case ConpherenceTransactionType::TYPE_PICTURE:
+        return $object->getImagePHID(ConpherenceImageData::SIZE_ORIG);
+      case ConpherenceTransactionType::TYPE_PICTURE_CROP:
+        return $object->getImagePHID(ConpherenceImageData::SIZE_CROP);
       case ConpherenceTransactionType::TYPE_PARTICIPANTS:
         if ($this->getIsNewObject()) {
           return array();
@@ -150,7 +156,11 @@ protected function getCustomTransactionNewValue(
 
     switch ($xaction->getTransactionType()) {
       case ConpherenceTransactionType::TYPE_TITLE:
+      case ConpherenceTransactionType::TYPE_PICTURE_CROP:
         return $xaction->getNewValue();
+      case ConpherenceTransactionType::TYPE_PICTURE:
+        $file = $xaction->getNewValue();
+        return $file->getPHID();
       case ConpherenceTransactionType::TYPE_PARTICIPANTS:
       case ConpherenceTransactionType::TYPE_FILES:
         return $this->getPHIDTransactionNewValue($xaction);
@@ -243,6 +253,16 @@ protected function applyCustomInternalTransaction(
       case ConpherenceTransactionType::TYPE_TITLE:
         $object->setTitle($xaction->getNewValue());
         break;
+      case ConpherenceTransactionType::TYPE_PICTURE:
+        $object->setImagePHID(
+          $xaction->getNewValue(),
+          ConpherenceImageData::SIZE_ORIG);
+        break;
+      case ConpherenceTransactionType::TYPE_PICTURE_CROP:
+        $object->setImagePHID(
+          $xaction->getNewValue(),
+          ConpherenceImageData::SIZE_CROP);
+        break;
       case ConpherenceTransactionType::TYPE_PARTICIPANTS:
         if (!$this->getIsNewObject()) {
           $old_map = array_fuse($xaction->getOldValue());
@@ -576,6 +596,20 @@ protected function getSearchContextParameter(
     );
   }
 
+  protected function extractFilePHIDsFromCustomTransaction(
+    PhabricatorLiskDAO $object,
+    PhabricatorApplicationTransaction $xaction) {
+
+    switch ($xaction->getTransactionType()) {
+      case ConpherenceTransactionType::TYPE_PICTURE:
+          return array($xaction->getNewValue()->getPHID());
+      case ConpherenceTransactionType::TYPE_PICTURE_CROP:
+          return array($xaction->getNewValue());
+    }
+
+    return parent::extractFilePHIDsFromCustomTransaction($object, $xaction);
+  }
+
   protected function validateTransaction(
     PhabricatorLiskDAO $object,
     $type,
@@ -608,6 +642,21 @@ protected function validateTransaction(
           $errors[] = $error;
         }
         break;
+      case ConpherenceTransactionType::TYPE_PICTURE:
+        foreach ($xactions as $xaction) {
+          $file = $xaction->getNewValue();
+          if (!$file->isTransformableImage()) {
+            $detail = pht('This server only supports these image formats: %s.',
+              implode(', ', PhabricatorFile::getTransformableImageFormats()));
+            $error = new PhabricatorApplicationTransactionValidationError(
+              $type,
+              pht('Invalid'),
+              $detail,
+              last($xactions));
+            $errors[] = $error;
+          }
+        }
+        break;
       case ConpherenceTransactionType::TYPE_PARTICIPANTS:
         foreach ($xactions as $xaction) {
           $new_phids = $this->getPHIDTransactionNewValue($xaction, array());