Skip to content

Commit 46c4459

Browse files
committed
Conpherence notifications - fix ordering
Summary: we get participation data ordered, then query conpherences by phid... be sure to resort the conpherences based on participation data. I missed this in testing 'cuz my test data is so trashy, but it is glaringly obvious in production. :/ Test Plan: replied to a very old conpherence and noted it was first in the notification panel Reviewers: chad, epriestley Reviewed By: epriestley CC: Korvin, aran Maniphest Tasks: T3641 Differential Revision: https://secure.phabricator.com/D6711
1 parent e6f3c24 commit 46c4459

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ public function processRequest() {
2828

2929
if ($conpherences) {
3030
require_celerity_resource('conpherence-notification-css');
31+
// re-order the conpherences based on participation data
32+
$conpherences = array_select_keys(
33+
$conpherences, array_keys($participant_data));
3134
$view = new AphrontNullView();
3235
foreach ($conpherences as $conpherence) {
3336
$p_data = $participant_data[$conpherence->getPHID()];

0 commit comments

Comments
 (0)