Skip to content

Commit 52dd354

Browse files
author
Chad Little
committed
Fix Conphernce sometimes searching wrong room
Summary: I passed this in as a config, but need to parse it live when threads change, otherwise the wrong room could be searched. Test Plan: Search in one room, click a second, search again, see correct results. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16707
1 parent 3593be4 commit 52dd354

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

resources/celerity/map.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@
436436
'rsrc/js/application/calendar/behavior-recurring-edit.js' => '5f1c4d5f',
437437
'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408',
438438
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2',
439-
'rsrc/js/application/conpherence/behavior-conpherence-search.js' => '3bc9d2b1',
439+
'rsrc/js/application/conpherence/behavior-conpherence-search.js' => 'dfa4e1ac',
440440
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'c5238acb',
441441
'rsrc/js/application/conpherence/behavior-menu.js' => '07928ca3',
442442
'rsrc/js/application/conpherence/behavior-participant-pane.js' => '8604caa8',
@@ -666,7 +666,7 @@
666666
'javelin-behavior-conpherence-menu' => '07928ca3',
667667
'javelin-behavior-conpherence-participant-pane' => '8604caa8',
668668
'javelin-behavior-conpherence-pontificate' => 'f2e58483',
669-
'javelin-behavior-conpherence-search' => '3bc9d2b1',
669+
'javelin-behavior-conpherence-search' => 'dfa4e1ac',
670670
'javelin-behavior-countdown-timer' => 'e4cc26b3',
671671
'javelin-behavior-dark-console' => 'f411b6ae',
672672
'javelin-behavior-dashboard-async-panel' => '469c0d9e',
@@ -1219,13 +1219,6 @@
12191219
'javelin-dom',
12201220
'javelin-magical-init',
12211221
),
1222-
'3bc9d2b1' => array(
1223-
'javelin-behavior',
1224-
'javelin-dom',
1225-
'javelin-util',
1226-
'javelin-workflow',
1227-
'javelin-stratcom',
1228-
),
12291222
'3cb0b2fc' => array(
12301223
'javelin-behavior',
12311224
'javelin-dom',
@@ -2095,6 +2088,13 @@
20952088
'df5e11d2' => array(
20962089
'javelin-install',
20972090
),
2091+
'dfa4e1ac' => array(
2092+
'javelin-behavior',
2093+
'javelin-dom',
2094+
'javelin-util',
2095+
'javelin-workflow',
2096+
'javelin-stratcom',
2097+
),
20982098
'e0ec7f2f' => array(
20992099
'javelin-behavior',
21002100
'javelin-dom',

src/applications/conpherence/controller/ConpherenceController.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,7 @@ protected function buildHeaderPaneContent(
113113
->setHref('#')
114114
->addClass('conpherence-participant-toggle'));
115115

116-
Javelin::initBehavior(
117-
'conpherence-search',
118-
array(
119-
'searchURI' => '/conpherence/threadsearch/'.$conpherence->getID().'/',
120-
));
116+
Javelin::initBehavior('conpherence-search');
121117

122118
$header->addActionItem(
123119
id(new PHUIIconCircleView())
@@ -187,6 +183,7 @@ public function buildSearchForm() {
187183
'action' => '/conpherence/threadsearch/'.$id.'/',
188184
'sigil' => 'conpherence-search-form',
189185
'class' => 'conpherence-search-form',
186+
'id' => 'conpherence-search-form',
190187
),
191188
array(
192189
$bar,

webroot/rsrc/js/application/conpherence/behavior-conpherence-search.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* javelin-stratcom
88
*/
99

10-
JX.behavior('conpherence-search', function(config) {
10+
JX.behavior('conpherence-search', function() {
1111

1212
var shown = true;
1313
var request = null;
@@ -24,13 +24,14 @@ JX.behavior('conpherence-search', function(config) {
2424
function _doSearch(e) {
2525
e.kill();
2626
var search_text = JX.$('conpherence-search-input').value;
27+
var search_uri = JX.$('conpherence-search-form').action;
2728
var search_node = JX.$('conpherence-search-results');
2829

2930
if (request || !search_text) {
3031
return;
3132
}
3233

33-
request = new JX.Request(config.searchURI, function(response) {
34+
request = new JX.Request(search_uri, function(response) {
3435
JX.DOM.setContent(search_node, JX.$H(response));
3536
request = null;
3637
});

0 commit comments

Comments
 (0)