Skip to content

Commit b467e58

Browse files
author
epriestley
committed
Fix two minor issues
Summary: Ref T7811. Fixes two minor issues I observed in the cluster: - Sometimes APC doesn't give us key names. Not sure exactly what's up here, but we can do a better job with this. - The `%` in `25%` actually needs more escaping, since it's interpreted by both `pht()` (immediately) and `console_format()` (later). Test Plan: - First one is just from an error log, not sure how to repro offhand. - Ran `bin/phd help start` for the second one. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7814, T7811 Differential Revision: https://secure.phabricator.com/D12395
1 parent d56012c commit b467e58

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/applications/cache/spec/PhabricatorDataCacheSpec.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ private function initAPCCommonSpec() {
8383
$cache = $info['cache_list'];
8484
$state = array();
8585
foreach ($cache as $item) {
86-
$key = self::getKeyPattern($item['info']);
86+
$info = idx($item, 'info', '<unknown-key>');
87+
$key = self::getKeyPattern($info);
8788
if (empty($state[$key])) {
8889
$state[$key] = array(
8990
'max' => 0,

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ protected function getAutoscaleReserveArgument() {
619619
'Specify a proportion of machine memory which must be free '.
620620
'before autoscale pools will grow. For example, a value of 0.25 '.
621621
'means that pools will not grow unless the machine has at least '.
622-
'25%% of its RAM free.'),
622+
'25%%%% of its RAM free.'),
623623
);
624624
}
625625

0 commit comments

Comments
 (0)